[PATCH V7 08/12] of: add notes of critical trips for soctherm

[PATCH V7 08/12] of: add notes of critical trips for soctherm

[Wei Ni]

The "critical" type trip in thermal zone can be
set to SOC_THERM hardware, it can trigger shut down
or reset event from hardware.

Signed-off-by: Wei Ni <wni@nvidia.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
index 6b68cd150405..351a7376baa8 100644
--- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
+++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
@@ -26,6 +26,10 @@ Required properties :
     of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
     list of valid values when referring to thermal sensors.
 
+Note:
+- the "critical" type trip points will be set to SOC_THERM hardware as the
+shut down temperature. Once the temperature of this thermal zone is higher
+than it, the system will be shutdown or reset by hardware.
 
 Example :
 
@@ -51,5 +55,13 @@ Example: referring to thermal sensors :
 
                         thermal-sensors =
                                 <&soctherm TEGRA124_SOCTHERM_SENSOR_CPU>;
+
+			trips {
+				cpu_shutdown_trip: shutdown-trip {
+					temperature = <102500>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
                 };
 	};
-- 
1.9.1

Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
> The "critical" type trip in thermal zone can be
> set to SOC_THERM hardware, it can trigger shut down
> or reset event from hardware.
> 
> Signed-off-by: Wei Ni <wni@nvidia.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

I did not see in your patch set an update on the compatible string for
the new chip. Did I miss something?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

[Wei Ni]

On 2016年03月15日 05:00, Eduardo Valentin wrote:
> * PGP Signed by an unknown key
> 
> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
>> The "critical" type trip in thermal zone can be
>> set to SOC_THERM hardware, it can trigger shut down
>> or reset event from hardware.
>>
>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
> 
> I did not see in your patch set an update on the compatible string for
> the new chip. Did I miss something?

As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
compatible string. At that time, it just used current tegra_soctherm.c driver to
support Tegra210, it can work, but can't show temperatures correctly.

> 
> * Unknown Key
> * 0x7DA4E256
> 

Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

[Wei Ni]

On 2016年03月15日 15:49, Wei Ni wrote:
> 
> 
> On 2016年03月15日 05:00, Eduardo Valentin wrote:
>> * PGP Signed by an unknown key
>>
>> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
>>> The "critical" type trip in thermal zone can be
>>> set to SOC_THERM hardware, it can trigger shut down
>>> or reset event from hardware.
>>>
>>> Signed-off-by: Wei Ni <wni@nvidia.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> ---
>>>  Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>
>> I did not see in your patch set an update on the compatible string for
>> the new chip. Did I miss something?
> 
> As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
> compatible string. At that time, it just used current tegra_soctherm.c driver to
> support Tegra210, it can work, but can't show temperatures correctly.

Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the
compatible string, did not use current tegra_soctherm driver to support Tegra210.

Wei.

> 
>>
>> * Unknown Key
>> * 0x7DA4E256
>>

Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Tue, Mar 15, 2016 at 04:14:15PM +0800, Wei Ni wrote:
> 
> 
> On 2016年03月15日 15:49, Wei Ni wrote:
> > 
> > 
> > On 2016年03月15日 05:00, Eduardo Valentin wrote:
> >> * PGP Signed by an unknown key
> >>
> >> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
> >>> The "critical" type trip in thermal zone can be
> >>> set to SOC_THERM hardware, it can trigger shut down
> >>> or reset event from hardware.
> >>>
> >>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >>> ---
> >>>  Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
> >>>  1 file changed, 12 insertions(+)
> >>
> >> I did not see in your patch set an update on the compatible string for
> >> the new chip. Did I miss something?
> > 
> > As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
> > compatible string. At that time, it just used current tegra_soctherm.c driver to
> > support Tegra210, it can work, but can't show temperatures correctly.
> 
> Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the
> compatible string, did not use current tegra_soctherm driver to support Tegra210.

Ok. got it. The binding is done, but the driver is being re factored only
now to add the support for this chip version.

> 
> Wei.
> 
> > 
> >>
> >> * Unknown Key
> >> * 0x7DA4E256
> >>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]