From: Dan Carpenter <dan.carpenter@oracle.com>
To: srinivas.pandruvada@linux.intel.com
Cc: linux-pm@vger.kernel.org
Subject: re: Thermal/int340x/processor_thermal: Enable auxiliary DTS for Braswell
Date: Thu, 17 Mar 2016 20:54:47 +0300 [thread overview]
Message-ID: <20160317175447.GA25085@mwanda> (raw)
Hello Srinivas Pandruvada,
The patch 4d0dd6c1576b: "Thermal/int340x/processor_thermal: Enable
auxiliary DTS for Braswell" from Mar 2, 2015, leads to the following
static checker warning:
drivers/thermal/int340x_thermal/processor_thermal_device.c:380 proc_thermal_pci_probe()
error: 'proc_priv->soc_dts' dereferencing possible ERR_PTR()
drivers/thermal/int340x_thermal/processor_thermal_device.c
362 /*
363 * Enumerate additional DTS sensors available via IOSF.
364 * But we are not treating as a failure condition, if
365 * there are no aux DTSs enabled or fails. This driver
366 * already exposes sensors, which can be accessed via
367 * ACPI/MSR. So we don't want to fail for auxiliary DTSs.
368 */
369 proc_priv->soc_dts = intel_soc_dts_iosf_init(
370 INTEL_SOC_DTS_INTERRUPT_MSI, 2, 0);
371
372 if (proc_priv->soc_dts && pdev->irq) {
^^^^^^^^^^^^^^^^^^
This can never be NULL. Only a valid pointer or an error pointer.
373 ret = pci_enable_msi(pdev);
374 if (!ret) {
375 ret = request_threaded_irq(pdev->irq, NULL,
376 proc_thermal_pci_msi_irq,
377 IRQF_ONESHOT, "proc_thermal",
378 pdev);
379 if (ret) {
380 intel_soc_dts_iosf_exit(
381 proc_priv->soc_dts);
382 pci_disable_msi(pdev);
383 proc_priv->soc_dts = NULL;
384 }
385 }
386 } else
387 dev_err(&pdev->dev, "No auxiliary DTSs enabled\n");
388 }
389
390 return 0;
391 }
regards,
dan carpenter
reply other threads:[~2016-03-17 17:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317175447.GA25085@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).