From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 3/3] drivers/cpufreq: make ppc_cbe_cpufreq_pmi driver explicitly non-modular Date: Mon, 28 Mar 2016 08:03:14 +0530 Message-ID: <20160328023314.GA28406@vireshk-i7> References: <1459116497-19991-1-git-send-email-paul.gortmaker@windriver.com> <1459116497-19991-4-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:34369 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbcC1CdS (ORCPT ); Sun, 27 Mar 2016 22:33:18 -0400 Received: by mail-pf0-f174.google.com with SMTP id x3so126133370pfb.1 for ; Sun, 27 Mar 2016 19:33:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1459116497-19991-4-git-send-email-paul.gortmaker@windriver.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Christian Krafft , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-pm@vger.kernel.org On 27-03-16, 18:08, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config CPU_FREQ_CBE_PMI > bool "CBE frequency scaling using PMI interface" > > ...meaning that it currently is not being built as a module by > anyone. Lets remove the modular and unused code here, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: Christian Krafft > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/cpufreq/ppc_cbe_cpufreq_pmi.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) Acked-by: Viresh Kumar -- viresh