linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Mason <slash.tmp@free.fr>
Cc: linux-pm <linux-pm@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Javi Merino <javi.merino@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Mans Rullgard <mans@mansr.com>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v6] thermal: add temperature sensor support for tango SoC
Date: Thu, 31 Mar 2016 18:52:41 -0700	[thread overview]
Message-ID: <20160401015240.GB19409@localhost.localdomain> (raw)
In-Reply-To: <56FD8582.80002@free.fr>

On Thu, Mar 31, 2016 at 10:16:02PM +0200, Mason wrote:
> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> 
> The Tango thermal driver provides support for the primitive temperature
> sensor embedded in Tango chips since the SMP8758.
> 
> This sensor only generates a 1-bit signal to indicate whether the die
> temperature exceeds a programmable threshold.
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
>  Documentation/devicetree/bindings/thermal/tango-thermal.txt |  17 ++++
>  drivers/thermal/Kconfig                                     |   9 ++
>  drivers/thermal/Makefile                                    |   1 +
>  drivers/thermal/tango_thermal.c                             | 125 +++++++++++++++++++++++++++
>  4 files changed, 152 insertions(+)

Based on previous versions discussion, I don't see issues with this
specific patch, despite the fact that it lacks a pointer to its doc (but looks
like there is none available).

The only request I do for now, as mentioned on v5, is to include in your
series the required dt changes to add thermal zones, describing the
needed typical trips for this chip.

BR,

Eduardo Valentin

  reply	other threads:[~2016-04-01  1:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 16:49 [RFC] Temperature sensor driver (tango) Mason
2016-03-04 15:52 ` [PATCH v2] thermal: add temperature sensor support for tango SoC Mason
2016-03-08 21:48   ` Eduardo Valentin
2016-03-21 10:31     ` Mason
2016-03-24 12:18     ` [PATCH v3] " Mason
2016-03-24 17:56       ` Mason
2016-03-27 20:35     ` [PATCH v4] " Mason
2016-03-28 11:49       ` [PATCH v5] " Mason
2016-03-29  2:00         ` Eduardo Valentin
2016-03-29 18:48           ` Mason
2016-03-30  0:05             ` Eduardo Valentin
2016-03-30 15:18               ` Mason
2016-03-31 20:16                 ` [PATCH v6] " Mason
2016-04-01  1:52                   ` Eduardo Valentin [this message]
2016-04-04 11:48                     ` Mason
2016-04-04 11:49                     ` [PATCH v7] " Mason
2016-04-05  2:05                       ` Eduardo Valentin
2016-04-05 14:58                       ` Mason
2016-04-06 15:48                         ` Eduardo Valentin
2016-04-06 15:51                       ` Eduardo Valentin
2016-04-13 20:28                         ` Mason
2016-04-19 14:21                         ` [PATCH v8 1/2] " Mason
2016-04-19 14:49                           ` Mason
2016-04-19 14:32                         ` [PATCH v8 2/2] ARM: dts: tango4: Initial thermal support Mason
2016-04-20 22:45                           ` Eduardo Valentin
2016-04-01  1:48                 ` [PATCH v5] thermal: add temperature sensor support for tango SoC Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401015240.GB19409@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=arnd@arndb.de \
    --cc=javi.merino@arm.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=slash.tmp@free.fr \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).