* [PATCH] cpuidle: Indicate when a device has been unregistered
@ 2016-04-05 19:05 Dave Gerlach
2016-04-06 19:00 ` Daniel Lezcano
0 siblings, 1 reply; 3+ messages in thread
From: Dave Gerlach @ 2016-04-05 19:05 UTC (permalink / raw)
To: linux-kernel, linux-pm; +Cc: Daniel Lezcano, Rafael J . Wysocki, Dave Gerlach
Currently the 'registered' member of the cpuidle_device struct is set
to 1 during cpuidle_register_device. In this same function there are
checks to see if the device is already registered to prevent duplicate
calls to register the device, but this value is never set to 0 even on
unregister of the device. Because of this, any attempt to call
cpuidle_register_device after a call to cpuidle_unregister_device will
fail which shouldn't be the case.
To prevent this, set registered to 0 when the device is unregistered.
Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
---
drivers/cpuidle/cpuidle.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index f996efc56605..c2dd99ab1648 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -433,6 +433,8 @@ static void __cpuidle_unregister_device(struct cpuidle_device *dev)
list_del(&dev->device_list);
per_cpu(cpuidle_devices, dev->cpu) = NULL;
module_put(drv->owner);
+
+ dev->registered = 0;
}
static void __cpuidle_device_init(struct cpuidle_device *dev)
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle: Indicate when a device has been unregistered
2016-04-05 19:05 [PATCH] cpuidle: Indicate when a device has been unregistered Dave Gerlach
@ 2016-04-06 19:00 ` Daniel Lezcano
2016-04-22 0:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2016-04-06 19:00 UTC (permalink / raw)
To: Dave Gerlach; +Cc: linux-kernel, linux-pm, Rafael J . Wysocki
On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> Currently the 'registered' member of the cpuidle_device struct is set
> to 1 during cpuidle_register_device. In this same function there are
> checks to see if the device is already registered to prevent duplicate
> calls to register the device, but this value is never set to 0 even on
> unregister of the device. Because of this, any attempt to call
> cpuidle_register_device after a call to cpuidle_unregister_device will
> fail which shouldn't be the case.
>
> To prevent this, set registered to 0 when the device is unregistered.
>
> Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle: Indicate when a device has been unregistered
2016-04-06 19:00 ` Daniel Lezcano
@ 2016-04-22 0:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-04-22 0:40 UTC (permalink / raw)
To: Daniel Lezcano, Dave Gerlach; +Cc: linux-kernel, linux-pm
On Wednesday, April 06, 2016 12:00:48 PM Daniel Lezcano wrote:
> On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> > Currently the 'registered' member of the cpuidle_device struct is set
> > to 1 during cpuidle_register_device. In this same function there are
> > checks to see if the device is already registered to prevent duplicate
> > calls to register the device, but this value is never set to 0 even on
> > unregister of the device. Because of this, any attempt to call
> > cpuidle_register_device after a call to cpuidle_unregister_device will
> > fail which shouldn't be the case.
> >
> > To prevent this, set registered to 0 when the device is unregistered.
> >
> > Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> > Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> > ---
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-22 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-05 19:05 [PATCH] cpuidle: Indicate when a device has been unregistered Dave Gerlach
2016-04-06 19:00 ` Daniel Lezcano
2016-04-22 0:40 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).