From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] cpufreq: Skip all governor-related actions for cpufreq_suspended set
Date: Thu, 7 Apr 2016 09:58:20 +0530 [thread overview]
Message-ID: <20160407042820.GA14903@vireshk-i7> (raw)
In-Reply-To: <2044559.GVlD7a2JcO@vostro.rjw.lan>
On 07-04-16, 03:29, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since governor operations are generally skipped if cpufreq_suspended
> is set, do nothing at all in cpufreq_start_governor() and
> cpufreq_exit_governor() in that case.
>
> In particular, this prevents fast frequency switching from being
> disabled after a suspend-to-RAM cycle on all CPUs except for the
> boot one.
static int cpufreq_governor(struct cpufreq_policy *policy, unsigned int event)
{
int ret;
/* Don't start any governor operations if we are entering suspend */
if (cpufreq_suspended)
return 0;
...
}
Above already guarantees that we would start/stop governors. Why do we
need this change then ?
--
viresh
next prev parent reply other threads:[~2016-04-07 4:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 1:29 [PATCH] cpufreq: Skip all governor-related actions for cpufreq_suspended set Rafael J. Wysocki
2016-04-07 4:28 ` Viresh Kumar [this message]
2016-04-07 11:22 ` Rafael J. Wysocki
2016-04-07 11:32 ` Viresh Kumar
2016-04-07 11:44 ` Rafael J. Wysocki
2016-04-07 12:05 ` Viresh Kumar
2016-04-07 22:05 ` Rafael J. Wysocki
2016-04-08 5:44 ` Viresh Kumar
2016-04-08 21:56 ` Rafael J. Wysocki
2016-04-08 5:45 ` Viresh Kumar
2016-04-08 21:54 ` Rafael J. Wysocki
2016-04-10 3:16 ` Viresh Kumar
2016-04-10 3:46 ` Rafael J. Wysocki
2016-04-10 4:08 ` [PATCH] cpufreq: Abort cpufreq_update_current_freq() " Rafael J. Wysocki
2016-04-10 4:10 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407042820.GA14903@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox