public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] cpufreq: Call cpufreq_disable_fast_switch() in sugov_exit()
Date: Fri, 8 Apr 2016 11:49:29 +0530	[thread overview]
Message-ID: <20160408061929.GG9674@vireshk-i7> (raw)
In-Reply-To: <2791888.n2Juh7mFmz@vostro.rjw.lan>

On 07-04-16, 23:38, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Due to differences in the cpufreq core's handling of runtime CPU
> offline and nonboot CPUs disabling during system suspend-to-RAM,
> fast frequency switching gets disabled after a suspend-to-RAM and
> resume cycle on all of the nonboot CPUs.
> 
> To prevent that from happening, move the invocation of
> cpufreq_disable_fast_switch() from cpufreq_exit_governor() to
> sugov_exit(), as the schedutil governor is the only user of fast
> frequency switching today anyway.
> 
> That simply prevents cpufreq_disable_fast_switch() from being called
> without invoking the ->governor callback for the CPUFREQ_GOV_POLICY_EXIT
> event (which happens during system suspend now).
> 
> Fixes: b7898fda5bc7 (cpufreq: Support for fast frequency switching)
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

      reply	other threads:[~2016-04-08  6:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 21:38 [PATCH] cpufreq: Call cpufreq_disable_fast_switch() in sugov_exit() Rafael J. Wysocki
2016-04-08  6:19 ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408061929.GG9674@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox