From: Viresh Kumar <viresh.kumar@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH 5/5] cpufreq: Loongson1: Replace goto out with return in ls1x_cpufreq_probe()
Date: Tue, 12 Apr 2016 10:54:17 +0530 [thread overview]
Message-ID: <20160412052417.GS16238@vireshk-i7> (raw)
In-Reply-To: <1460375759-20705-5-git-send-email-keguang.zhang@gmail.com>
On 11-04-16, 19:55, Keguang Zhang wrote:
> From: Kelvin Cheung <keguang.zhang@gmail.com>
>
> This patch replaces goto out with return in ls1x_cpufreq_probe(),
> and also includes some minor fixes.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
> drivers/cpufreq/loongson1-cpufreq.c | 37 ++++++++++++++++---------------------
> 1 file changed, 16 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/cpufreq/loongson1-cpufreq.c b/drivers/cpufreq/loongson1-cpufreq.c
> index 5074f5e..1bc90af 100644
> --- a/drivers/cpufreq/loongson1-cpufreq.c
> +++ b/drivers/cpufreq/loongson1-cpufreq.c
> @@ -1,7 +1,7 @@
> /*
> * CPU Frequency Scaling for Loongson 1 SoC
> *
> - * Copyright (C) 2014 Zhang, Keguang <keguang.zhang@gmail.com>
> + * Copyright (C) 2014-2016 Zhang, Keguang <keguang.zhang@gmail.com>
Actually you should fold above into the first patch of the series,
that renames this file. It makes much sense that way.
> *
> * This file is licensed under the terms of the GNU General Public
> * License version 2. This program is licensed "as is" without any
> @@ -141,7 +141,8 @@ static int ls1x_cpufreq_probe(struct platform_device *pdev)
> struct clk *clk;
> int ret;
>
> - if (!pdata || !pdata->clk_name || !pdata->osc_clk_name)
> + if (!pdata || !pdata->clk_name || !pdata->osc_clk_name) {
You added a '{' here, but the closing '}' is added way down..
Something is wrong here I feel..
> + dev_err(&pdev->dev, "platform data missing\n");
> return -EINVAL;
>
> cpufreq =
> @@ -155,8 +156,7 @@ static int ls1x_cpufreq_probe(struct platform_device *pdev)
> if (IS_ERR(clk)) {
> dev_err(&pdev->dev, "unable to get %s clock\n",
> pdata->clk_name);
> - ret = PTR_ERR(clk);
> - goto out;
> + return PTR_ERR(clk);
> }
> static struct platform_driver ls1x_cpufreq_platdrv = {
> - .driver = {
> + .probe = ls1x_cpufreq_probe,
> + .remove = ls1x_cpufreq_remove,
> + .driver = {
> .name = "ls1x-cpufreq",
> },
> - .probe = ls1x_cpufreq_probe,
> - .remove = ls1x_cpufreq_remove,
Why do this change at all? Do it in the first patch if you really want
to.
> };
>
> module_platform_driver(ls1x_cpufreq_platdrv);
>
> MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>");
> -MODULE_DESCRIPTION("Loongson 1 CPUFreq driver");
> +MODULE_DESCRIPTION("Loongson1 CPUFreq driver");
This one as well, move it to the first patch.
> MODULE_LICENSE("GPL");
> --
> 1.9.1
--
viresh
next prev parent reply other threads:[~2016-04-12 5:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 11:55 [PATCH 1/5] cpufreq: Loongson1: Rename the file to loongson1-cpufreq.c Keguang Zhang
2016-04-11 11:55 ` [PATCH 2/5] cpufreq: Loongson1: Replace kzalloc() with kcalloc() Keguang Zhang
2016-04-12 5:18 ` Viresh Kumar
2016-04-11 11:55 ` [PATCH 3/5] cpufreq: Loongson1: Use dev_get_platdata() to get platform_data Keguang Zhang
2016-04-12 5:18 ` Viresh Kumar
2016-04-11 11:55 ` [PATCH 4/5] cpufreq: Loongson1: Use devm_kzalloc() instead of global structure Keguang Zhang
2016-04-12 5:20 ` Viresh Kumar
2016-04-11 11:55 ` [PATCH 5/5] cpufreq: Loongson1: Replace goto out with return in ls1x_cpufreq_probe() Keguang Zhang
2016-04-12 5:24 ` Viresh Kumar [this message]
2016-04-12 5:17 ` [PATCH 1/5] cpufreq: Loongson1: Rename the file to loongson1-cpufreq.c Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412052417.GS16238@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).