From: Brian Norris <briannorris@chromium.org>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Caesar Wang <wxt@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
dianders@chromium.org, smbarber@google.com,
linux-rockchip@lists.infradead.org,
Mikko Perttunen <mperttunen@nvidia.com>,
Paul Walmsley <pwalmsley@nvidia.com>, Wei Ni <wni@nvidia.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip points
Date: Wed, 20 Apr 2016 18:12:30 -0700 [thread overview]
Message-ID: <20160421011230.GA118377@google.com> (raw)
In-Reply-To: <20160420234818.GB2558@localhost.localdomain>
+ Sascha
On Wed, Apr 20, 2016 at 04:48:18PM -0700, Eduardo Valentin wrote:
> On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote:
> > From: Mikko Perttunen <mperttunen@nvidia.com>
> >
> > This adds support for hardware-tracked trip points to the device tree
> <cut>
>
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> > index 97b86c5..6ef932a 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -335,12 +335,14 @@ struct thermal_genl_event {
> > * @get_trend: a pointer to a function that reads the sensor temperature trend.
> > * @set_emul_temp: a pointer to a function that sets sensor emulated
> > * temperature.
> > + * @set_trips: a pointer to a function that set low/high trip temperature.
> > */
> > struct thermal_zone_of_device_ops {
> > int (*get_temp)(void *, int *);
> > int (*get_trend)(void *, long *);
> > int (*set_emul_temp)(void *, int);
> > int (*set_trip_temp)(void *, int, int);
> > + int (*set_trips)(void *, int, int);
>
> This is unfortunately a diverges from API available on thermal core. Can
> you please add first on thermal core then, use it in of thermal?
>
> I don't want to have callbacks available only via of thermal. If we
> allow it, OF thermal becomes a separate API.
What ever happened to this effort?
http://thread.gmane.org/gmane.linux.power-management.general/59451
Patch 12 and 13 look to accomplish something similar, yet they do what
Eduardo suggested. I was testing that series at my previous job, but
unfortunately (for the fate of this series) I left that employer before
I could finish reviewing and testing it. Perhaps Caesar can resurrect
and test it?
Brian
next prev parent reply other threads:[~2016-04-21 1:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 3:35 [PATCH 0/9] thermal: rockchip: Support rk3366/rk3399 SoCS and fixes the driver Caesar Wang
2016-04-18 3:35 ` [PATCH 1/9] thermal: rockchip: disable thermal->clk in err case Caesar Wang
2016-04-18 3:35 ` [PATCH 2/9] thermal: rockchip: fixes the code_to_temp for tsadc driver Caesar Wang
2016-04-18 3:35 ` [PATCH 3/9] thermal: rockchip: update the tsadc table for rk3399 Caesar Wang
2016-04-18 3:35 ` [PATCH 4/9] thermal: rockchip: handle the power sequence for tsadc controller Caesar Wang
2016-04-27 23:48 ` Eduardo Valentin
[not found] ` <57216C65.5040501@gmail.com>
2016-04-28 15:04 ` Eduardo Valentin
2016-05-03 2:27 ` Caesar Wang
2016-04-18 3:35 ` [PATCH 5/9] thermal: rockchip: Support RK3366 SoCs in the thermal driver Caesar Wang
2016-04-18 3:35 ` [PATCH 6/9] thermal: rockchip: add the notes for better reading Caesar Wang
2016-04-18 3:35 ` [PATCH 7/9] thermal: of: Add support for hardware-tracked trip points Caesar Wang
2016-04-20 23:48 ` Eduardo Valentin
2016-04-21 1:12 ` Brian Norris [this message]
2016-04-22 1:54 ` Caesar Wang
2016-04-22 5:41 ` Sascha Hauer
2016-04-22 10:17 ` Caesar Wang
2016-04-27 21:50 ` Eduardo Valentin
2016-04-18 3:36 ` [PATCH 8/9] thermal: rockchip: add the set_trips function Caesar Wang
2016-04-27 23:52 ` [PATCH 0/9] thermal: rockchip: Support rk3366/rk3399 SoCS and fixes the driver Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421011230.GA118377@google.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mperttunen@nvidia.com \
--cc=pwalmsley@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=smbarber@google.com \
--cc=wni@nvidia.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).