From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v1] cpufreq: rockchip: Use generic platdev driver Date: Thu, 21 Apr 2016 14:17:26 +0530 Message-ID: <20160421084726.GB9309@vireshk-i7> References: <1461225849-36866-1-git-send-email-finley.xiao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1461225849-36866-1-git-send-email-finley.xiao@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Finlye Xiao Cc: linux@arm.linux.org.uk, rjw@rjwysocki.net, heiko@sntech.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, wxt@rock-chips.com, jay.xu@rock-chips.com, rocky.hao@rock-chips.com, tim.chen@rock-chips.com, tony.xie@rock-chips.com, ulysses.huang@rock-chips.com List-Id: linux-pm@vger.kernel.org On 21-04-16, 16:04, Finlye Xiao wrote: > From: Finley Xiao > > This patch add rockchip's compatible string to the compat list and > remove similar code from platform code for supporting generic platdev > driver. > > Signed-off-by: Finley Xiao > --- > arch/arm/mach-rockchip/rockchip.c | 1 - > drivers/cpufreq/cpufreq-dt-platdev.c | 10 ++++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/rockchip.c b/arch/arm/mach-rockchip/rockchip.c > index 3f07cc5..beb71da 100644 > --- a/arch/arm/mach-rockchip/rockchip.c > +++ b/arch/arm/mach-rockchip/rockchip.c > @@ -74,7 +74,6 @@ static void __init rockchip_dt_init(void) > { > rockchip_suspend_init(); > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > - platform_device_register_simple("cpufreq-dt", 0, NULL, 0); > } > > static const char * const rockchip_board_dt_compat[] = { > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index f2ae7ad..2128767 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -21,6 +21,16 @@ static const struct of_device_id machines[] = { > { .compatible = "samsung,exynos5420", }, > { .compatible = "samsung,exynos5800", }, > #endif Please enter a blank line here. > + { .compatible = "rockchip,rk2928", }, > + { .compatible = "rockchip,rk3036", }, > + { .compatible = "rockchip,rk3066a", }, > + { .compatible = "rockchip,rk3066b", }, > + { .compatible = "rockchip,rk3188", }, > + { .compatible = "rockchip,rk3228", }, > + { .compatible = "rockchip,rk3288", }, > + { .compatible = "rockchip,rk3366", }, > + { .compatible = "rockchip,rk3368", }, > + { .compatible = "rockchip,rk3399", }, > }; > > static int __init cpufreq_dt_platdev_init(void) So you won just by few minutes, I have sent an almost similar patch just now. Anyway, you sent it first, that's all.. Please resend after the blank line. Acked-by: Viresh Kumar -- viresh