From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms without operating-points-v2 Date: Fri, 22 Apr 2016 15:27:36 -0700 Message-ID: <20160422222736.GU13149@codeaurora.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:59557 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbcDVW1j (ORCPT ); Fri, 22 Apr 2016 18:27:39 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, arnd.bergmann@linaro.org, andrew@lunn.ch, gregory.clement@free-electrons.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org On 04/21, Viresh Kumar wrote: > @@ -167,14 +167,16 @@ static int cpufreq_init(struct cpufreq_policy *policy) > /* Get OPP-sharing information from "operating-points-v2" bindings */ > ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus); > if (ret) { > + if (ret != -ENOENT) > + goto out_put_clk; > + > /* > * operating-points-v2 not supported, fallback to old method of > - * finding shared-OPPs for backward compatibility. > + * finding shared-OPPs for backward compatibility if the > + * platform hasn't set sharing CPUs. > */ > - if (ret == -ENOENT) > - opp_v1 = true; > - else > - goto out_put_clk; > + if (dev_pm_opp_get_sharing_cpus(cpu_dev, policy->cpus)) > + fallback = true; I'm sort of lost, we make the same call twice here. Why would the return value change between the first time and the second? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project