From: Viresh Kumar <viresh.kumar@linaro.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
arnd.bergmann@linaro.org, andrew@lunn.ch,
gregory.clement@free-electrons.com, jason@lakedaemon.net,
sebastian.hesselbarth@gmail.com,
thomas.petazzoni@free-electrons.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls
Date: Wed, 27 Apr 2016 08:17:04 +0530 [thread overview]
Message-ID: <20160427024704.GB22326@vireshk-i7> (raw)
In-Reply-To: <20160422155941.23e1d05b@lxorguk.ukuu.org.uk>
On 22-04-16, 15:59, One Thousand Gnomes wrote:
> On Fri, 22 Apr 2016 14:42:31 +0200
> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>
> > On Friday, April 22, 2016 08:46:51 AM Viresh Kumar wrote:
> > > Some of the routines have use -ENOSYS, which is supposed to be used only
> > > for syscalls. Replace that with -EINVAL.
> >
> > -EINVAL specifically means "invalid argument".
> >
> > What about using -ENXIO instead?
>
> That specifically means "device not present", but might be reasonable.
> Quite a bit of the kernel uses EOPNOTSUPP (operation not supported).
That looks reasonable to me.. Will switch to that.
> Before you change it though please check how existing userspace does
> error handling. It's nice to use more "correct" error codes, but that's
> not sufficient reason if it turns out that existing user space checks for
> ENOSYS for example.
Userspace doesn't interact directly with this stuff, its pretty much within the
kernel. So it should be fine.
Thanks Alan.
--
viresh
next prev parent reply other threads:[~2016-04-27 2:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 8:58 [PATCH 00/10] cpufreq: Get rid of cpufreq-dt's platform data Viresh Kumar
2016-04-21 8:58 ` [PATCH 01/10] PM / OPP: Propagate the error returned by _find_opp_table() Viresh Kumar
2016-04-22 22:14 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 02/10] PM / OPP: Add missing doc style comments Viresh Kumar
2016-04-22 22:15 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 03/10] PM / OPP: dev_pm_opp_set_sharing_cpus() doesn't depend on CONFIG_OF Viresh Kumar
2016-04-22 22:16 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 04/10] PM / OPP: Relocate dev_pm_opp_set_sharing_cpus() Viresh Kumar
2016-04-22 22:22 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 05/10] PM / OPP: Mark shared-opp for non-dt case Viresh Kumar
2016-04-22 22:21 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 06/10] PM / OPP: Add dev_pm_opp_get_sharing_cpus() Viresh Kumar
2016-04-22 22:21 ` Stephen Boyd
2016-04-27 2:59 ` Viresh Kumar
2016-04-21 8:58 ` [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms without operating-points-v2 Viresh Kumar
2016-04-22 22:27 ` Stephen Boyd
2016-04-25 9:36 ` Viresh Kumar
2016-04-25 21:45 ` Stephen Boyd
2016-04-25 21:48 ` Rafael J. Wysocki
2016-04-25 21:56 ` Stephen Boyd
2016-04-25 22:03 ` Rafael J. Wysocki
2016-04-21 8:59 ` [PATCH 08/10] mvebu: Use dev_pm_opp_set_sharing_cpus() to mark OPP tables as shared Viresh Kumar
2016-04-22 22:24 ` Stephen Boyd
2016-04-21 8:59 ` [PATCH 09/10] cpufreq: dt: Kill platform-data Viresh Kumar
2016-04-22 22:26 ` Stephen Boyd
2016-04-21 8:59 ` [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar
2016-04-22 22:42 ` Arnd Bergmann
2016-04-25 3:00 ` Viresh Kumar
2016-04-25 12:53 ` Arnd Bergmann
2016-04-25 12:56 ` Viresh Kumar
2016-04-25 15:26 ` Arnd Bergmann
2016-04-25 15:29 ` Viresh Kumar
2016-04-25 15:46 ` Arnd Bergmann
2016-04-25 15:55 ` Thomas Petazzoni
2016-04-21 20:10 ` [PATCH 00/10] cpufreq: Get rid of cpufreq-dt's platform data Rafael J. Wysocki
2016-04-22 3:16 ` [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls Viresh Kumar
2016-04-22 12:42 ` Rafael J. Wysocki
2016-04-22 14:59 ` One Thousand Gnomes
2016-04-27 2:47 ` Viresh Kumar [this message]
2016-04-22 22:44 ` [PATCH 00/10] cpufreq: Get rid of cpufreq-dt's platform data Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427024704.GB22326@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew@lunn.ch \
--cc=arnd.bergmann@linaro.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox