From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value Date: Thu, 28 Apr 2016 10:20:23 +0200 Message-ID: <20160428082023.GA10216@linaro.org> References: <1461669301-30834-1-git-send-email-james.morse@arm.com> <20160426113103.GB2204@red-moon> <20160427091434.GA4303@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:35537 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbcD1IU3 (ORCPT ); Thu, 28 Apr 2016 04:20:29 -0400 Received: by mail-wm0-f42.google.com with SMTP id e201so67007112wme.0 for ; Thu, 28 Apr 2016 01:20:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160427091434.GA4303@red-moon> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Lorenzo Pieralisi Cc: "Rafael J. Wysocki" , James Morse , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , lina.iyer@linaro.org On Wed, Apr 27, 2016 at 10:14:34AM +0100, Lorenzo Pieralisi wrote: > [+ Lina] > > On Tue, Apr 26, 2016 at 09:05:57PM +0200, Rafael J. Wysocki wrote: > > On Tue, Apr 26, 2016 at 1:31 PM, Lorenzo Pieralisi > > wrote: > > > On Tue, Apr 26, 2016 at 12:15:01PM +0100, James Morse wrote: > > >> arm_cpuidle_suspend() may return -EOPNOTSUPP, or any value returned > > >> by the cpu_ops/cpuidle_ops suspend call. arm_enter_idle_state() doesn't > > >> update 'ret' with this value, meaning we always signal success to > > >> cpuidle_enter_state(), causing it to update the usage counters as if we > > >> succeeded. > > >> > > >> Fixes: 191de17aa3c1 ("ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function") > > >> Signed-off-by: James Morse > > >> --- > > >> drivers/cpuidle/cpuidle-arm.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Acked-by: Lorenzo Pieralisi Acked-by: Daniel Lezcano