From: Viresh Kumar <viresh.kumar@linaro.org>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: linux-kernel@vger.kernel.org,
Rufus Hamade <rufus.hamade@imgtec.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] Fix CONFIG_PM_OPP without CONFIG_OF build failure
Date: Thu, 5 May 2016 08:31:09 +0530 [thread overview]
Message-ID: <20160505030109.GG2573@vireshk-i7> (raw)
In-Reply-To: <1462281278-8553-1-git-send-email-eric.engestrom@imgtec.com>
On 03-05-16, 14:14, Eric Engestrom wrote:
> diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
> index ba2bdbd..8aae170 100644
> --- a/drivers/base/power/opp/cpu.c
> +++ b/drivers/base/power/opp/cpu.c
> @@ -119,6 +119,7 @@ void dev_pm_opp_free_cpufreq_table(struct device *dev,
> EXPORT_SYMBOL_GPL(dev_pm_opp_free_cpufreq_table);
> #endif /* CONFIG_CPU_FREQ */
>
> +#ifdef CONFIG_OF
> /* Required only for V1 bindings, as v2 can manage it from DT itself */
> int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
> {
> @@ -160,7 +161,6 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
> }
> EXPORT_SYMBOL_GPL(dev_pm_opp_set_sharing_cpus);
>
> -#ifdef CONFIG_OF
> void dev_pm_opp_of_cpumask_remove_table(cpumask_var_t cpumask)
> {
> struct device *cpu_dev;
This change was incorrect as this API can be used for non-OF case.
Some things have already changed, can you please rebase on linux-next
and resend this patch?
--
viresh
next prev parent reply other threads:[~2016-05-05 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 13:14 [PATCH] Fix CONFIG_PM_OPP without CONFIG_OF build failure Eric Engestrom
2016-05-05 3:01 ` Viresh Kumar [this message]
2016-05-05 9:14 ` [PATCH v2] " Eric Engestrom
2016-05-05 9:20 ` Sudeep Holla
2016-05-05 10:52 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505030109.GG2573@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=eric.engestrom@imgtec.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rufus.hamade@imgtec.com \
--cc=sboyd@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox