From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v2] Fix CONFIG_PM_OPP without CONFIG_OF build failure Date: Thu, 5 May 2016 16:22:12 +0530 Message-ID: <20160505105212.GL2573@vireshk-i7> References: <20160505030109.GG2573@vireshk-i7> <1462439658-4523-1-git-send-email-eric.engestrom@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f180.google.com ([209.85.192.180]:33516 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757002AbcEEKwQ (ORCPT ); Thu, 5 May 2016 06:52:16 -0400 Received: by mail-pf0-f180.google.com with SMTP id 206so36738026pfu.0 for ; Thu, 05 May 2016 03:52:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sudeep Holla Cc: Eric Engestrom , Rufus Hamade , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Linux PM list , open list On 05-05-16, 10:20, Sudeep Holla wrote: > On Thu, May 5, 2016 at 10:14 AM, Eric Engestrom > wrote: > > From: Rufus Hamade > > > > A few `#ifdef CONFIG_OF` were missing, resulting in "unused function" > > warnings in core.c. > > > > Signed-off-by: Rufus Hamade > > Reviewed-by: Eric Engestrom > > Tested-by: Eric Engestrom > > --- > > v2: drop incorrect change in cpu.c (Viresh Kumar) > > > > On Thu, May 05, 2016 at 08:31:09AM +0530, Viresh Kumar wrote: > >> Some things have already changed, can you please rebase on linux-next > >> and resend this patch? > > > > I rebased on top of linux-next (30d0993ec9f6) from the repo > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm > > but there were no change (the patch is identical, save for the > > removed change in cpu.c; not even a line number changed). > > Which repo did you want me to rebase on? > > > > I posted some changes around this a week ago, I see Rafael has pulled into > his bleeding-edge[1] patch this morning. If no issue are found, it > should eventually > make to linux-next in couple of days. I have tried to fix all these issues differently, most of you are cc'd on that patch: [PATCH] PM / OPP: Move CONFIG_OF dependent code in a separate file -- viresh