* [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init()
@ 2016-05-04 8:27 Geert Uytterhoeven
2016-05-09 7:51 ` Ulf Hansson
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2016-05-04 8:27 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson, Laurent Pinchart,
linux-renesas-soc, linux-pm, Geert Uytterhoeven
All local setup of the generic_pm_domain structure should have been
completed before calling pm_genpd_init().
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/mach-shmobile/pm-rmobile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c
index ecc92bad3500c1c1..175bd3d91ebcbcb4 100644
--- a/arch/arm/mach-shmobile/pm-rmobile.c
+++ b/arch/arm/mach-shmobile/pm-rmobile.c
@@ -131,13 +131,13 @@ static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd)
struct dev_power_governor *gov = rmobile_pd->gov;
genpd->flags = GENPD_FLAG_PM_CLK;
- pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
genpd->dev_ops.active_wakeup = rmobile_pd_active_wakeup;
genpd->power_off = rmobile_pd_power_down;
genpd->power_on = rmobile_pd_power_up;
genpd->attach_dev = cpg_mstp_attach_dev;
genpd->detach_dev = cpg_mstp_detach_dev;
__rmobile_pd_power_up(rmobile_pd, false);
+ pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
}
static int rmobile_pd_suspend_busy(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init()
2016-05-04 8:27 [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init() Geert Uytterhoeven
@ 2016-05-09 7:51 ` Ulf Hansson
2016-05-10 0:01 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2016-05-09 7:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Magnus Damm, Rafael J. Wysocki, Kevin Hilman,
Laurent Pinchart, linux-renesas-soc, linux-pm@vger.kernel.org
On 4 May 2016 at 10:27, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> All local setup of the generic_pm_domain structure should have been
> completed before calling pm_genpd_init().
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> arch/arm/mach-shmobile/pm-rmobile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c
> index ecc92bad3500c1c1..175bd3d91ebcbcb4 100644
> --- a/arch/arm/mach-shmobile/pm-rmobile.c
> +++ b/arch/arm/mach-shmobile/pm-rmobile.c
> @@ -131,13 +131,13 @@ static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd)
> struct dev_power_governor *gov = rmobile_pd->gov;
>
> genpd->flags = GENPD_FLAG_PM_CLK;
> - pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
> genpd->dev_ops.active_wakeup = rmobile_pd_active_wakeup;
> genpd->power_off = rmobile_pd_power_down;
> genpd->power_on = rmobile_pd_power_up;
> genpd->attach_dev = cpg_mstp_attach_dev;
> genpd->detach_dev = cpg_mstp_detach_dev;
> __rmobile_pd_power_up(rmobile_pd, false);
> + pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
> }
>
> static int rmobile_pd_suspend_busy(void)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init()
2016-05-09 7:51 ` Ulf Hansson
@ 2016-05-10 0:01 ` Simon Horman
2016-05-20 4:24 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2016-05-10 0:01 UTC (permalink / raw)
To: Ulf Hansson
Cc: Geert Uytterhoeven, Magnus Damm, Rafael J. Wysocki, Kevin Hilman,
Laurent Pinchart, linux-renesas-soc, linux-pm@vger.kernel.org
On Mon, May 09, 2016 at 09:51:05AM +0200, Ulf Hansson wrote:
> On 4 May 2016 at 10:27, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > All local setup of the generic_pm_domain structure should have been
> > completed before calling pm_genpd_init().
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Hi Geert,
I have it in mind to queue this up for v4.8.
Please let me know if you have other ideas.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init()
2016-05-10 0:01 ` Simon Horman
@ 2016-05-20 4:24 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-05-20 4:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: Geert Uytterhoeven, Magnus Damm, Rafael J. Wysocki, Kevin Hilman,
Laurent Pinchart, linux-renesas-soc, linux-pm@vger.kernel.org
On Tue, May 10, 2016 at 09:01:35AM +0900, Simon Horman wrote:
> On Mon, May 09, 2016 at 09:51:05AM +0200, Ulf Hansson wrote:
> > On 4 May 2016 at 10:27, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > > All local setup of the generic_pm_domain structure should have been
> > > completed before calling pm_genpd_init().
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Hi Geert,
>
> I have it in mind to queue this up for v4.8.
> Please let me know if you have other ideas.
I have queued this up for v4.8.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-20 4:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 8:27 [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init() Geert Uytterhoeven
2016-05-09 7:51 ` Ulf Hansson
2016-05-10 0:01 ` Simon Horman
2016-05-20 4:24 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).