From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never fails
Date: Fri, 13 May 2016 08:43:48 +0530 [thread overview]
Message-ID: <20160513031348.GA3415@vireshk-i7> (raw)
In-Reply-To: <10942818.DP54y8SPGY@vostro.rjw.lan>
On 12-05-16, 15:13, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> None of the cpufreq governors currently in the tree will ever fail
> an invocation of the ->governor() callback with the event argument
> equal to CPUFREQ_GOV_POLICY_EXIT (unless invoked with incorrect
> arguments which doesn't matter anyway) and it wouldn't really
> make sense to fail it, because the caller won't be able to handle
> that failure in a meaningful way.
>
> Accordingly, rearrange the code in the core to make it clear that
> this call never fails.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq.c | 35 ++++++++++++-----------------------
> 1 file changed, 12 insertions(+), 23 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-05-13 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 13:12 [PATCH 0/2] cpufreq: Avoid checking governor return values that are always 0 Rafael J. Wysocki
2016-05-12 13:13 ` [PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never fails Rafael J. Wysocki
2016-05-13 3:13 ` Viresh Kumar [this message]
2016-05-12 13:14 ` [PATCH 2/2] cpufreq: governor: CPUFREQ_GOV_STOP " Rafael J. Wysocki
2016-05-13 3:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513031348.GA3415@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox