From: Eduardo Valentin <edubezval@gmail.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 20/31] thermal: core: introduce thermal_helpers.c
Date: Tue, 17 May 2016 07:40:45 -0700 [thread overview]
Message-ID: <20160517144044.GB14550@localhost.localdomain> (raw)
In-Reply-To: <1463491216.29980.36.camel@rzhang1-mobl4>
On Tue, May 17, 2016 at 01:20:17PM +0000, Zhang, Rui wrote:
> $checkpatch.pl 20-31-thermal-core-introduce-thermal_helpers.c.patch
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need
> updating?
> #187:
> new file mode 100644
>
> ERROR: trailing whitespace
> #302: FILE: drivers/thermal/thermal_helpers.c:111:
> + $
>
> WARNING: please, no spaces at the start of a line
> #302: FILE: drivers/thermal/thermal_helpers.c:111:
> + $
>
> total: 1 errors, 2 warnings, 287 lines checked
>
> NOTE: Whitespace errors detected.
> You may wish to use scripts/cleanpatch or scripts/cleanfile
>
> 20-31-thermal-core-introduce-thermal_helpers.c.patch has style problems,
> please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Please remove these spaces.
> BTW, there are also some warnings in the other patches, please fix the
> checkpatch warnings/errors.
Yeah, I will fix those.
These patches were supposed to be reviewed/merged before the merge
window though. I am going to wait until the merge window is closed to
send them again.
BR,
Eduardo Valentin
next prev parent reply other threads:[~2016-05-17 14:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 6:02 [PATCH 00/31] thermal: reorganizing thermal core Eduardo Valentin
2016-05-04 6:02 ` [PATCH 01/31] thermal: core: prevent zones with no types to be registered Eduardo Valentin
2016-05-04 6:02 ` [PATCH 02/31] thermal: core: group thermal_zone DEVICE_ATTR's declarations Eduardo Valentin
2016-05-04 6:02 ` [PATCH 03/31] thermal: core: group device_create_file() calls that are always created Eduardo Valentin
2016-05-04 6:02 ` [PATCH 04/31] thermal: core: use dev.groups to manage always present tz attributes Eduardo Valentin
2016-05-04 6:02 ` [PATCH 05/31] thermal: core: move emul_temp creation to tz->device.groups Eduardo Valentin
2016-05-04 6:02 ` [PATCH 06/31] thermal: core: move mode attribute " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 07/31] thermal: core: move passive attr " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 08/31] thermal: core: move power actor code out of sysfs I/F section Eduardo Valentin
2016-05-04 6:02 ` [PATCH 09/31] thermal: core: move the trip attrs to the tz " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 10/31] thermal: core: create tz->device.groups dynamically Eduardo Valentin
2016-05-04 6:02 ` [PATCH 11/31] thermal: core: move trips attributes to tz->device.groups Eduardo Valentin
2016-05-04 6:02 ` [PATCH 12/31] thermal: core: remove unnecessary device_remove() calls Eduardo Valentin
2016-05-04 6:02 ` [PATCH 13/31] thermal: core: split passive_store Eduardo Valentin
2016-05-04 6:02 ` [PATCH 14/31] thermal: core: split policy_store Eduardo Valentin
2016-05-04 6:02 ` [PATCH 15/31] thermal: core: split available_policies_show() Eduardo Valentin
2016-05-04 6:02 ` [PATCH 16/31] thermal: core: move to_thermal_zone() macro to header file Eduardo Valentin
2016-05-04 6:02 ` [PATCH 17/31] thermal: core: move thermal_zone sysfs to thermal_sysfs.c Eduardo Valentin
2016-05-04 6:02 ` [PATCH 18/31] thermal: core: move to_cooling_device macro to header file Eduardo Valentin
2016-05-04 6:02 ` [PATCH 19/31] thermal: core: move cooling device sysfs to thermal_sysfs.c Eduardo Valentin
2016-05-04 6:02 ` [PATCH 20/31] thermal: core: introduce thermal_helpers.c Eduardo Valentin
2016-05-17 13:20 ` Zhang, Rui
2016-05-17 14:40 ` Eduardo Valentin [this message]
2016-05-30 16:05 ` Eduardo Valentin
2016-05-04 6:02 ` [PATCH 21/31] thermal: core: group functions related to governor handling Eduardo Valentin
2016-05-04 6:02 ` [PATCH 22/31] thermal: core: move idr handling to device management section Eduardo Valentin
2016-05-04 6:02 ` [PATCH 23/31] thermal: core: move __unbind() helper to where it is used Eduardo Valentin
2016-05-04 6:02 ` [PATCH 24/31] thermal: core: move bind_cdev() " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 25/31] thermal: core: move bind_tz() " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 26/31] thermal: core: move __bind() " Eduardo Valentin
2016-05-04 6:02 ` [PATCH 27/31] thermal: core: add inline to print_bind_err_msg() Eduardo Valentin
2016-05-04 6:02 ` [PATCH 28/31] thermal: core: move notify to the zone update section Eduardo Valentin
2016-05-04 6:02 ` [PATCH 29/31] thermal: core: add a comment describing the main update loop Eduardo Valentin
2016-05-04 6:02 ` [PATCH 30/31] thermal: core: add a comment describing the power actor section Eduardo Valentin
2016-05-04 6:02 ` [PATCH 31/31] thermal: core: add a comment describing the device management section Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517144044.GB14550@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).