From: "Pali Rohár" <pali.rohar@gmail.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: "Andrew F. Davis" <afd@ti.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: Should 9aafabc7fece be reverted?
Date: Thu, 19 May 2016 11:17:19 +0200 [thread overview]
Message-ID: <20160519091719.GL29844@pali> (raw)
In-Reply-To: <573D60B4.7010906@gmail.com>
On Thursday 19 May 2016 09:44:04 Ivaylo Dimitrov wrote:
> Hi,
>
> On 18.05.2016 19:58, Andrew F. Davis wrote:
> >Hello all,
> >
> >Why do we need this patch? I removed giving each battery a number in its
> >name intentionally. It doesn't seem to be needed anymore, and only two
> >old drivers out of the ~70 power supply drivers do this.
> >
>
> The patch is needed because commit <703df6c09795> breaks existing userspace
> on Nokia N900, which counts on name numbering. Also, commit <703df6c09795>
> description says nothing about name changing, so I assumed it is an
> unintentional side-effect of splitting the code into modules.
Right, changing name cause breaking userspace and that commit does not
describe anything about changing name. So also from my perspective it is
regression.
> You are not listed and as I try to avoid making more noise than needed when
> sending patches, I didn't include you in CC. Apologies if I should have
> CC-ed you.
Maybe in future it could make sense to CC author of commit which
introduced regression...
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-05-19 9:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:58 Should 9aafabc7fece be reverted? Andrew F. Davis
2016-05-19 6:44 ` Ivaylo Dimitrov
2016-05-19 9:17 ` Pali Rohár [this message]
2016-05-19 9:34 ` Ivaylo Dimitrov
2016-05-19 15:38 ` Andrew F. Davis
2016-05-19 15:44 ` Pali Rohár
2016-05-19 15:48 ` Andrew F. Davis
2016-05-19 15:51 ` Pali Rohár
2016-05-19 15:57 ` Andrew F. Davis
2016-05-19 16:06 ` Pali Rohár
2016-05-19 16:11 ` Andrew F. Davis
2016-05-19 16:18 ` Pali Rohár
2016-05-19 16:46 ` Andrew F. Davis
2016-05-20 9:29 ` Pavel Machek
2016-05-23 15:55 ` Andrew F. Davis
2016-05-23 16:10 ` Pali Rohár
2016-05-23 16:29 ` Andrew F. Davis
2016-05-20 9:34 ` Pavel Machek
2016-05-20 10:35 ` Pali Rohár
2016-05-23 16:05 ` Andrew F. Davis
2016-05-20 9:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519091719.GL29844@pali \
--to=pali.rohar@gmail.com \
--cc=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).