From: Pavel Machek <pavel@ucw.cz>
To: "Andrew F. Davis" <afd@ti.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
linux-pm@vger.kernel.org
Subject: Re: Should 9aafabc7fece be reverted?
Date: Fri, 20 May 2016 11:29:27 +0200 [thread overview]
Message-ID: <20160520092927.GB4580@amd> (raw)
In-Reply-To: <573DEDFF.8060305@ti.com>
Hi!
> >>>>> No, it is not driver name, but device name. That is different.
> >>>>
> >>>> My bad, that's what I meant, device names should be dynamic,
> >>>> right? Relying on them being static in software would then be
> >>>> buggy (like relying on eth0 being the right NIC everytime)?
> >>>>
> >>>> I'm not familiar with the N900 software, but IDR can give out
> >>>> different numbers and may not always give the first battery #0 (it
> >>>> does now but is that a guarantee in IDR?) and if not then what is
> >>>> the userspace response to this changing?
> >>>
> >>> In case N900 would have more bq27xxx batteries, then yes. But N900
> >>> has exactly *one* bq27200 battery, so there is no IDR problem.
> >>
> >> Right, but if IDR returns 42 instead of 0 would this then break its
> >> userspace software?
> >
> > I think it is insane to starts generating random numbers for IDR... Hard
> > to decide what happen if such situation occur...
> >
>
> That's kind of what I'm looking for though, if the userspace break is
> caused by software relying on the battery to be named "bq27200-0", then
> nothing short of hard-coding this exact name will 100% safely fix the
> N900 userspace software. And so using IDR and hoping it gives 0 is just
> a hacky work-around way of just naming the device "bq27200-0".
N900 userspace is not intended to be portable. (And actually current
kernel support does not allow writing portable userspace for a
phone. It presents _3_ power supplies to userspace. How is userspace
expected to deal with that?)
And if you ever name the single battery bq27200-42 or bq27200-1337,
you'll have a flock of angry penguins at your doorstep.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-05-20 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:58 Should 9aafabc7fece be reverted? Andrew F. Davis
2016-05-19 6:44 ` Ivaylo Dimitrov
2016-05-19 9:17 ` Pali Rohár
2016-05-19 9:34 ` Ivaylo Dimitrov
2016-05-19 15:38 ` Andrew F. Davis
2016-05-19 15:44 ` Pali Rohár
2016-05-19 15:48 ` Andrew F. Davis
2016-05-19 15:51 ` Pali Rohár
2016-05-19 15:57 ` Andrew F. Davis
2016-05-19 16:06 ` Pali Rohár
2016-05-19 16:11 ` Andrew F. Davis
2016-05-19 16:18 ` Pali Rohár
2016-05-19 16:46 ` Andrew F. Davis
2016-05-20 9:29 ` Pavel Machek [this message]
2016-05-23 15:55 ` Andrew F. Davis
2016-05-23 16:10 ` Pali Rohár
2016-05-23 16:29 ` Andrew F. Davis
2016-05-20 9:34 ` Pavel Machek
2016-05-20 10:35 ` Pali Rohár
2016-05-23 16:05 ` Andrew F. Davis
2016-05-20 9:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520092927.GB4580@amd \
--to=pavel@ucw.cz \
--cc=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).