From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Steve Muckle <smuckle@linaro.org>
Subject: Re: [PATCH 0/2] cpufreq: Use sorted frequency tables
Date: Wed, 1 Jun 2016 16:12:43 +0530 [thread overview]
Message-ID: <20160601104243.GL3725@vireshk-i7> (raw)
In-Reply-To: <CAJZ5v0ig61Q+EDjjcyHef5e9B4dKY+BhF802uV61w-G5CdRQvA@mail.gmail.com>
On 01-06-16, 00:50, Rafael J. Wysocki wrote:
> I'm not particularly liking this due to the possible confusion that
> may result from it.
I have gotten rid of most of it now in V2.
> Perhaps we can require drivers implementing ->fast_switch to sort
> their frequency tables to start with?
I wasn't *only* concerned about the fast-switch case, but the case of
normal governors that we use today. After all that's what everybody is
using right now.
And I feel (Maybe you as well), that we are better off using a single
optimized path for all cases. Otherwise things start getting too messy
too soon.
> Or maybe make the core check
> whether or not the table is sorted
Platforms are already broken for this, and so wouldn't be possible to
check for existing governors.
> and in what order and handle it
> accordingly?
We should really be handling a single order to avoid complications in
it :)
> Let's just think about the design here for a while, OK?
Sure. Lets see how bad is V2.
--
viresh
next prev parent reply other threads:[~2016-06-01 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:36 [PATCH 0/2] cpufreq: Use sorted frequency tables Viresh Kumar
2016-05-31 11:36 ` [PATCH 1/2] cpufreq: Store sorted frequency table Viresh Kumar
2016-05-31 11:36 ` [PATCH 2/2] cpufreq: Implement cpufreq_find_target_index() to traverse sorted list Viresh Kumar
2016-05-31 22:50 ` [PATCH 0/2] cpufreq: Use sorted frequency tables Rafael J. Wysocki
2016-06-01 1:08 ` Steve Muckle
2016-06-01 10:46 ` Viresh Kumar
2016-06-01 19:23 ` Steve Muckle
2016-06-01 16:40 ` Rafael J. Wysocki
2016-06-01 19:37 ` Steve Muckle
2016-06-01 20:17 ` Rafael J. Wysocki
2016-06-01 10:42 ` Viresh Kumar [this message]
2016-06-01 16:37 ` Rafael J. Wysocki
2016-06-02 1:25 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601104243.GL3725@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox