From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: edubezval@gmail.com, linux-pm@vger.kernel.org,
javi.merino@arm.com, amit.kachhap@gmail.com, rui.zhang@intel.com
Subject: Re: [PATCH] thermal: cpu_cooling: fix improper order during initialization
Date: Wed, 1 Jun 2016 19:09:38 +0530 [thread overview]
Message-ID: <20160601133938.GQ3725@vireshk-i7> (raw)
In-Reply-To: <574EE3B7.1060302@arm.com>
On 01-06-16, 14:31, Lukasz Luba wrote:
>
>
> On 01/06/16 12:10, Viresh Kumar wrote:
> >On 31-05-16, 11:32, Lukasz Luba wrote:
> >>The freq_table array is not populated before calling
> >>thermal_of_cooling_register. The code which populates the freq table was
> >>introduced in commit f6859014.
> >>This should be done before registering new thermal cooling device.
> >>The log shows effects of this wrong decision.
> >>[ 2.172614] cpu cpu1: Failed to get voltage for frequency 1984518656000: -34
> >>[ 2.220863] cpu cpu0: Failed to get voltage for frequency 1984524416000: -34
> >>
> >
> >You should have added this as well:
> >
> >Cc: 4.19+ <stable@vger.kernel.org> # 4.19+
>
> You mean 3.19+
> Cc: <stable@vger.kernel.org> # 3.19+
Urg.
Thanks for fixing this :)
--
viresh
next prev parent reply other threads:[~2016-06-01 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 10:32 [PATCH] thermal: cpu_cooling: fix improper order during initialization Lukasz Luba
2016-06-01 8:36 ` Javi Merino
2016-06-01 11:10 ` Viresh Kumar
2016-06-01 13:31 ` Lukasz Luba
2016-06-01 13:39 ` Viresh Kumar [this message]
2016-06-01 14:27 ` Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601133938.GQ3725@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox