From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
dave.hansen@linux.intel.com, adrian.hunter@intel.com,
ak@linux.intel.com, luto@kernel.org, dvhart@infradead.org,
dougthompson@xmission.com, edubezval@gmail.com, hpa@zytor.com,
mingo@redhat.com, jacob.jun.pan@linux.intel.com,
kan.liang@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-edac@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-pm@vger.kernel.org, mchehab@osg.samsung.com,
peterz@infradead.org, platform-driver-x86@vger.kernel.org,
rafael.j.wysocki@intel.com, rajneesh.bhardwaj@intel.com,
souvik.k.chakravarty@intel.com,
srinivas.pandruvada@linux.intel.com, eranian@google.com,
tglx@linutronix.de, tony.luck@intel.com, ulf.hansson@linaro.org,
viresh.kumar@linaro.org, vishwanath.somayaji@intel.com,
zheng.z.yan@intel.com, rui.zhang@intel.com
Subject: Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers
Date: Thu, 2 Jun 2016 08:57:15 +0200 [thread overview]
Message-ID: <20160602065715.GA10803@pd.tnic> (raw)
In-Reply-To: <20160602001157.D8BE59D7@viggo.jf.intel.com>
On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote:
> +#define INTEL_FAM6_MODEL_CORE_YONAH 0x0E
> +#define INTEL_FAM6_MODEL_CORE2_MEROM 0x0F
That "MODEL_" part looks redundant too IMO - you could simply do
INTEL_FAM6_NEHALEM and
INTEL_FAM6_SKYLAKE_DESKTOP
...
and so on and it is still clear what it is.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-06-02 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 0:11 [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers Dave Hansen
2016-06-02 0:12 ` [PATCH 04/20] x86, intel_idle: use Intel family macros for intel_idle Dave Hansen
2016-06-02 0:12 ` [PATCH 07/20] x86, intel: use Intel model macros intead of open-coding Dave Hansen
2016-06-02 0:12 ` [PATCH 08/20] x86, rapl: reorder cpu detection table Dave Hansen
2016-06-02 0:12 ` [PATCH 13/20] x86, cpufreq: use Intel family name macros for intel_pstate cpufreq driver Dave Hansen
2016-06-02 0:12 ` [PATCH 18/20] x86, thermal: clean up and fix cpu model detection for intel_soc_dts_thermal Dave Hansen
2016-06-02 0:12 ` [PATCH 20/20] x86, powercap, rapl: add Skylake Server model number Dave Hansen
2016-06-02 6:57 ` Borislav Petkov [this message]
2016-06-02 21:49 ` [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers Rafael J. Wysocki
2016-06-02 21:45 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602065715.GA10803@pd.tnic \
--to=bp@alien8.de \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=dougthompson@xmission.com \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kan.liang@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rajneesh.bhardwaj@intel.com \
--cc=rui.zhang@intel.com \
--cc=souvik.k.chakravarty@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vishwanath.somayaji@intel.com \
--cc=x86@kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).