From: Alan <gnomes@lxorguk.ukuu.org.uk>
To: "dbasehore ." <dbasehore@chromium.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 5/5] intel_idle: Add S0ix validation
Date: Sat, 4 Jun 2016 13:22:13 +0100 [thread overview]
Message-ID: <20160604132213.18eb7d82@lxorguk.ukuu.orguk> (raw)
In-Reply-To: <CAGAzgsrgH5-v2u8kfmxzGKzTqGV1nqp+Yo4E7y96yrretKTkXA@mail.gmail.com>
> I would expect those IP blocks to do nothing and not block lower power
> states if the firmware is not loaded. If that is not the case, I think
> that should be fixed such that those lower power states are at least
> available during suspend (if not during runtime). If your Skylake+
> system is not entering S0ix during freeze, I consider that a bug that
> needs to be addressed.
You would assume wrongly. Several parts of the system do their own
power management so if present need to have a driver loaded. Graphics
is the example everyone is familiar with but ADSP audio and ISH are two
others.
> configs, that's their decision. As I said, this does nothing in the
> !CONFIG_INTEL_PMC_CORE case, but if a finer level config is warranted,
> I can add that.
IMHO it belongs as a config item because it has a power cost, and you
can't turn it off without enabling debugfs when it's compiled in.
> I would prefer if others used this more, since there would be better
> debug coverage and I would have to fix fewer bugs.
I'd be more concerned about getting 10,000 emails bisecting the warning
to your commit 8)
Alan
next prev parent reply other threads:[~2016-06-04 12:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 4:33 [PATCH 0/5] Add suspend-to-idle validation for Intel SoCs dbasehore
2016-06-02 4:33 ` [PATCH 1/5] x86: stub out pmc function dbasehore
2016-06-02 4:33 ` [PATCH 2/5] clockevents: Add timed freeze dbasehore
2016-06-02 4:33 ` [PATCH 3/5] x86, apic: Add timed freeze support dbasehore
2016-06-02 4:33 ` [PATCH 4/5] freeze: Add error reporting dbasehore
2016-06-02 4:33 ` [PATCH 5/5] intel_idle: Add S0ix validation dbasehore
2016-06-02 9:25 ` Peter Zijlstra
2016-06-02 13:23 ` One Thousand Gnomes
2016-06-02 18:31 ` dbasehore .
2016-06-02 18:55 ` dbasehore .
2016-06-02 19:53 ` One Thousand Gnomes
2016-06-02 20:35 ` dbasehore .
2016-06-04 12:22 ` Alan [this message]
2016-06-06 21:39 ` dbasehore .
2016-06-07 7:46 ` [PATCH 0/5] Add suspend-to-idle validation for Intel SoCs Pavel Machek
2016-06-08 0:07 ` dbasehore .
2016-06-11 20:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604132213.18eb7d82@lxorguk.ukuu.orguk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dbasehore@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).