Re: [PATCH v2 4/5] mfd: tps65217: Add power button as subdevice

[Lee Jones <lee.jones@linaro.org>]

On Wed, 15 Jun 2016, Marcin Niestroj wrote:

> Hi,
> 
> On 15.06.2016 16:12, Lee Jones wrote:
> >On Tue, 14 Jun 2016, Marcin Niestroj wrote:
> >
> >>Add tps65217 power buttor subdevice with assigned IRQ resources.
> >>
> >>Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> >>---
> >>depends on patch 1 in series
> >>
> >> drivers/mfd/tps65217.c | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >
> >Applied, thanks.
> 
> Did you also apply patch 1? As I stated above, this patch depends on
> patch 1.

Nope.  It looks like you still have changes to make.

What does it rely on?  The IRQ define?

> >>diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> >>index d49f94e..68cf431 100644
> >>--- a/drivers/mfd/tps65217.c
> >>+++ b/drivers/mfd/tps65217.c
> >>@@ -38,6 +38,10 @@ static struct resource charger_resources[] = {
> >> 	DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_USB, "USB"),
> >> };
> >>
> >>+static struct resource pb_resources[] = {
> >>+	DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_PB, "PB"),
> >>+};
> >>+
> >> struct tps65217_irq {
> >> 	int mask;
> >> 	int interrupt;
> >>@@ -122,6 +126,12 @@ static struct mfd_cell tps65217s[] = {
> >> 		.resources = charger_resources,
> >> 		.of_compatible = "ti,tps65217-charger",
> >> 	},
> >>+	{
> >>+		.name = "tps65217-pwrbutton",
> >>+		.num_resources = ARRAY_SIZE(pb_resources),
> >>+		.resources = pb_resources,
> >>+		.of_compatible = "ti,tps65217-pwrbutton",
> >>+	},
> >> };
> >>
> >> static irqreturn_t tps65217_irq_thread(int irq, void *data)
> >
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog