From: Dan Carpenter <dan.carpenter@oracle.com>
To: rnayak@codeaurora.org
Cc: linux-pm@vger.kernel.org
Subject: [bug report] thermal: qcom: tsens-8974: Add support for 8974 family of SoCs
Date: Tue, 5 Jul 2016 19:46:57 +0300 [thread overview]
Message-ID: <20160705164657.GA1379@mwanda> (raw)
Hello Rajendra Nayak,
The patch ffd6a56b9a88: "thermal: qcom: tsens-8974: Add support for
8974 family of SoCs" from May 5, 2016, leads to the following static
checker warning:
drivers/thermal/qcom/tsens-8974.c:152 calibrate_8974()
warn: mask and shift to zero
drivers/thermal/qcom/tsens-8974.c
141 case ONE_PT_CALIB:
142 case ONE_PT_CALIB2:
143 base1 = bkp[0] & BASE1_MASK;
144 p1[0] = (bkp[0] & S0_P1_MASK) >> S0_P1_SHIFT;
145 p1[1] = (bkp[0] & S1_P1_MASK) >> S1_P1_SHIFT;
146 p1[2] = (bkp[0] & S2_P1_MASK) >> S2_P1_SHIFT;
147 p1[3] = (bkp[0] & S3_P1_MASK) >> S3_P1_SHIFT;
148 p1[4] = (bkp[1] & S4_P1_MASK);
149 p1[5] = (bkp[1] & S5_P1_MASK) >> S5_P1_SHIFT;
150 p1[6] = (bkp[1] & S6_P1_MASK) >> S6_P1_SHIFT;
151 p1[7] = (bkp[1] & S7_P1_MASK) >> S7_P1_SHIFT;
152 p1[8] = (bkp[2] & S8_P1_MASK_BKP) >> S8_P1_SHIFT;
0x3f >> 24 is zero. This looks like a cut-and-paste bug but it's not
clear to me what was intended.
153 p1[9] = (bkp[2] & S9_P1_MASK_BKP) >> S9_P1_BKP_SHIFT;
154 p1[10] = (bkp[2] & S10_P1_MASK_BKP) >> S10_P1_BKP_SHIFT;
155 break;
156 }
regards,
dan carpenter
reply other threads:[~2016-07-05 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705164657.GA1379@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-pm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).