From: Viresh Kumar <viresh.kumar@linaro.org>
To: weiyj_lk@163.com
Cc: Keguang Zhang <keguang.zhang@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-mips@linux-mips.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH -next] CPUFREQ: Loongson1: Fix return value check in ls1x_cpufreq_probe()
Date: Wed, 6 Jul 2016 07:14:41 -0700 [thread overview]
Message-ID: <20160706141441.GJ2671@ubuntu> (raw)
In-Reply-To: <1467807655-31952-1-git-send-email-weiyj_lk@163.com>
On 06-07-16, 12:20, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function clk_get_parent() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.
NULL is a valid clock as per the clk-API and so this patch is wrong.
You need to investigate why you are getting NULL here for your
platform.
--
viresh
prev parent reply other threads:[~2016-07-06 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:20 [PATCH -next] CPUFREQ: Loongson1: Fix return value check in ls1x_cpufreq_probe() weiyj_lk
2016-07-06 14:14 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706141441.GJ2671@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).