From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] PM-wakeup: Delete unnecessary checks before three function calls Date: Thu, 28 Jul 2016 21:33:34 +0200 Message-ID: <20160728193334.GB11657@amd> References: <5307CAA2.8060406@users.sourceforge.net> <5786434.e97HVzPjpI@vostro.rjw.lan> <1722549.jyvuK0dZRm@vostro.rjw.lan> <88d6d524-c093-4fcd-35ba-ff19f7b21fe2@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <88d6d524-c093-4fcd-35ba-ff19f7b21fe2@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org To: SF Markus Elfring Cc: linux-pm@vger.kernel.org, Greg Kroah-Hartman , Len Brown , "Rafael J. Wysocki" , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-pm@vger.kernel.org On Sat 2016-07-23 17:14:00, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 23 Jul 2016 17:04:00 +0200 > > The following functions test whether their argument is NULL > and then return immediately. > * dev_pm_arm_wake_irq > * dev_pm_disarm_wake_irq > * wakeup_source_unregister > > Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html