From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominik Brodowski Subject: Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() Date: Mon, 1 Aug 2016 09:29:57 +0200 Message-ID: <20160801072957.GA4220@light.dominikbrodowski.net> References: <3752826.3sXAQIvcIA@vostro.rjw.lan> <2892951.2FPdDYdaoa@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2892951.2FPdDYdaoa@vostro.rjw.lan> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Linux PM list , Peter Zijlstra , Srinivas Pandruvada , Viresh Kumar , Linux Kernel Mailing List , Steve Muckle , Juri Lelli , Ingo Molnar List-Id: linux-pm@vger.kernel.org A small nitpick: On Mon, Aug 01, 2016 at 01:36:01AM +0200, Rafael J. Wysocki wrote: > --- linux-pm.orig/kernel/sched/sched.h > +++ linux-pm/kernel/sched/sched.h > @@ -1760,7 +1760,7 @@ DECLARE_PER_CPU(struct update_util_data > > /** > * cpufreq_update_util - Take a note about CPU utilization changes. > - * @time: Current time. > + * @rq: Runqueue to carry out the update for. > * > * This function is called by the scheduler on every invocation of > * update_load_avg() on the CPU whose utilization is being updated. This comment seems to need an update due to the smp_processor_id() check being moved into this function. Best, Dominik