From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v5 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Date: Wed, 10 Aug 2016 11:02:54 +0800 Message-ID: <20160810030254.GD1879@shlinux2> References: <1470646331-23227-1-git-send-email-peter.chen@nxp.com> <1470646331-23227-7-git-send-email-peter.chen@nxp.com> <57AA684F.4020004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <57AA684F.4020004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joshua Clayton Cc: Peter Chen , gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw3-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org, troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org, festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, oscar-Bdbr4918Nnnk1uMJSBkQmQ@public.gmane.org, stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: linux-pm@vger.kernel.org On Tue, Aug 09, 2016 at 04:33:35PM -0700, Joshua Clayton wrote: > Hi Peter, > > On 08/08/2016 01:52 AM, Peter Chen wrote: > > The current dts describes USB HUB's property at USB controller's > > entry, it is improper. The USB HUB should be the child node > > under USB controller, and power sequence properties are under > > it. > > > > Signed-off-by: Peter Chen > > --- > > arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi > > index 3bee2f9..f29a72c2f 100644 > > --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi > > @@ -9,6 +9,8 @@ > > * > > */ > > > > +#include > > + > > / { > > aliases { > > backlight = &backlight; > > @@ -58,17 +60,6 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > > > - reg_usb_h1_vbus: regulator@0 { > > - compatible = "regulator-fixed"; > > - reg = <0>; > > - regulator-name = "usb_h1_vbus"; > > - regulator-min-microvolt = <5000000>; > > - regulator-max-microvolt = <5000000>; > > - enable-active-high; > > - startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */ > > - gpio = <&gpio7 12 0>; > > - }; > > - > > reg_panel: regulator@1 { > > compatible = "regulator-fixed"; > > reg = <1>; > > @@ -259,9 +250,18 @@ > > &usbh1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_usbh>; > > - vbus-supply = <®_usb_h1_vbus>; > > - clocks = <&clks IMX6QDL_CLK_CKO>; > > status = "okay"; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > Assuming they are needed, > #address-cells and #size-cells should go in imx6qdl.dtsi, > rather than in board dts files, shouldn't they? Yes, you are right. All imx USB controller has only one port. > > + usb2415: hub@1 { > > + compatible = "usb424,2514"; > > + reg = <1>; > Does have any effect? > I couldn't find any reference to it in the patches. > (so apologies if it is in core code) > Does it matter? Please see 69bec7259853 ("USB: core: let USB device know device node") for detail. > Would it be possible to connect > more than one hub to the same usb phy? No possible for current imx, but possible for other SoCs. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html