* [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries [not found] <1470697311-1292-1-git-send-email-bhe@redhat.com> @ 2016-08-08 23:01 ` Baoquan He 2016-08-10 12:53 ` Ingo Molnar 0 siblings, 1 reply; 5+ messages in thread From: Baoquan He @ 2016-08-08 23:01 UTC (permalink / raw) To: linux-kernel Cc: Baoquan He, Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm It won't impact the result, we still should fix the code bug. Signed-off-by: Baoquan He <bhe@redhat.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Len Brown <len.brown@intel.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Cc: linux-pm@vger.kernel.org --- arch/x86/kernel/acpi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 90d84c3..2b25d3f 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void) return ret; } - x2count = madt_proc[0].count; - count = madt_proc[1].count; + count = madt_proc[0].count; + x2count = madt_proc[1].count; } if (!count && !x2count) { printk(KERN_ERR PREFIX "No LAPIC entries present\n"); -- 2.5.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries 2016-08-08 23:01 ` [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He @ 2016-08-10 12:53 ` Ingo Molnar 2016-08-10 13:03 ` Baoquan He 0 siblings, 1 reply; 5+ messages in thread From: Ingo Molnar @ 2016-08-10 12:53 UTC (permalink / raw) To: Baoquan He Cc: linux-kernel, Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm * Baoquan He <bhe@redhat.com> wrote: > It won't impact the result, we still should fix the code bug. > > Signed-off-by: Baoquan He <bhe@redhat.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: x86@kernel.org > Cc: linux-pm@vger.kernel.org > --- > arch/x86/kernel/acpi/boot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > index 90d84c3..2b25d3f 100644 > --- a/arch/x86/kernel/acpi/boot.c > +++ b/arch/x86/kernel/acpi/boot.c > @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void) > return ret; > } > > - x2count = madt_proc[0].count; > - count = madt_proc[1].count; > + count = madt_proc[0].count; > + x2count = madt_proc[1].count; > } > if (!count && !x2count) { > printk(KERN_ERR PREFIX "No LAPIC entries present\n"); Why does this bug have no effect? Thanks, Ingo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries 2016-08-10 12:53 ` Ingo Molnar @ 2016-08-10 13:03 ` Baoquan He 2016-08-11 8:46 ` Ingo Molnar 0 siblings, 1 reply; 5+ messages in thread From: Baoquan He @ 2016-08-10 13:03 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm On 08/10/16 at 02:53pm, Ingo Molnar wrote: > > * Baoquan He <bhe@redhat.com> wrote: > > > It won't impact the result, we still should fix the code bug. > > > > Signed-off-by: Baoquan He <bhe@redhat.com> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Len Brown <len.brown@intel.com> > > Cc: Pavel Machek <pavel@ucw.cz> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > Cc: x86@kernel.org > > Cc: linux-pm@vger.kernel.org > > --- > > arch/x86/kernel/acpi/boot.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > > index 90d84c3..2b25d3f 100644 > > --- a/arch/x86/kernel/acpi/boot.c > > +++ b/arch/x86/kernel/acpi/boot.c > > @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void) > > return ret; > > } > > > > - x2count = madt_proc[0].count; > > - count = madt_proc[1].count; > > + count = madt_proc[0].count; > > + x2count = madt_proc[1].count; > > } > > if (!count && !x2count) { ~~~~~~~~~~~~~~~~~~~~~ I mean here the value checking won't be impacted by the wrong assignment. > > printk(KERN_ERR PREFIX "No LAPIC entries present\n"); > > Why does this bug have no effect? > > Thanks, > > Ingo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries 2016-08-10 13:03 ` Baoquan He @ 2016-08-11 8:46 ` Ingo Molnar 2016-08-11 14:20 ` Baoquan He 0 siblings, 1 reply; 5+ messages in thread From: Ingo Molnar @ 2016-08-11 8:46 UTC (permalink / raw) To: Baoquan He Cc: linux-kernel, Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm * Baoquan He <bhe@redhat.com> wrote: > On 08/10/16 at 02:53pm, Ingo Molnar wrote: > > > > * Baoquan He <bhe@redhat.com> wrote: > > > > > It won't impact the result, we still should fix the code bug. > > > > > > Signed-off-by: Baoquan He <bhe@redhat.com> > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > Cc: Len Brown <len.brown@intel.com> > > > Cc: Pavel Machek <pavel@ucw.cz> > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > > Cc: Ingo Molnar <mingo@redhat.com> > > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > > Cc: x86@kernel.org > > > Cc: linux-pm@vger.kernel.org > > > --- > > > arch/x86/kernel/acpi/boot.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > > > index 90d84c3..2b25d3f 100644 > > > --- a/arch/x86/kernel/acpi/boot.c > > > +++ b/arch/x86/kernel/acpi/boot.c > > > @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void) > > > return ret; > > > } > > > > > > - x2count = madt_proc[0].count; > > > - count = madt_proc[1].count; > > > + count = madt_proc[0].count; > > > + x2count = madt_proc[1].count; > > > } > > > if (!count && !x2count) { > ~~~~~~~~~~~~~~~~~~~~~ > I mean here the value checking won't be impacted by the wrong > assignment. Indeed! Mind putting that into the changelog? Something like: "By pure accident the bug makes no functional difference, because the only expression where we are using these values is (!count && !x2count), in which the variables are interchangeable, but it makes sense to fix the bug nevertheless." Thanks, Ingo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries 2016-08-11 8:46 ` Ingo Molnar @ 2016-08-11 14:20 ` Baoquan He 0 siblings, 0 replies; 5+ messages in thread From: Baoquan He @ 2016-08-11 14:20 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm On 08/11/16 at 10:46am, Ingo Molnar wrote: > > > > - count = madt_proc[1].count; > > > > + count = madt_proc[0].count; > > > > + x2count = madt_proc[1].count; > > > > } > > > > if (!count && !x2count) { > > ~~~~~~~~~~~~~~~~~~~~~ > > I mean here the value checking won't be impacted by the wrong > > assignment. > > Indeed! > > Mind putting that into the changelog? Something like: > > "By pure accident the bug makes no functional difference, because the only > expression where we are using these values is (!count && !x2count), in which > the variables are interchangeable, but it makes sense to fix the bug > nevertheless." Sure, this is much clearer. Will use this and repost. Thanks a lot, will try to do each post using patch log like this. Thanks Baoquan ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-11 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1470697311-1292-1-git-send-email-bhe@redhat.com>
2016-08-08 23:01 ` [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He
2016-08-10 12:53 ` Ingo Molnar
2016-08-10 13:03 ` Baoquan He
2016-08-11 8:46 ` Ingo Molnar
2016-08-11 14:20 ` Baoquan He
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).