From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries
Date: Thu, 11 Aug 2016 22:20:26 +0800 [thread overview]
Message-ID: <20160811142026.GA26981@x1.redhat.com> (raw)
In-Reply-To: <20160811084652.GA4249@gmail.com>
On 08/11/16 at 10:46am, Ingo Molnar wrote:
> > > > - count = madt_proc[1].count;
> > > > + count = madt_proc[0].count;
> > > > + x2count = madt_proc[1].count;
> > > > }
> > > > if (!count && !x2count) {
> > ~~~~~~~~~~~~~~~~~~~~~
> > I mean here the value checking won't be impacted by the wrong
> > assignment.
>
> Indeed!
>
> Mind putting that into the changelog? Something like:
>
> "By pure accident the bug makes no functional difference, because the only
> expression where we are using these values is (!count && !x2count), in which
> the variables are interchangeable, but it makes sense to fix the bug
> nevertheless."
Sure, this is much clearer. Will use this and repost. Thanks a lot, will
try to do each post using patch log like this.
Thanks
Baoquan
prev parent reply other threads:[~2016-08-11 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470697311-1292-1-git-send-email-bhe@redhat.com>
2016-08-08 23:01 ` [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He
2016-08-10 12:53 ` Ingo Molnar
2016-08-10 13:03 ` Baoquan He
2016-08-11 8:46 ` Ingo Molnar
2016-08-11 14:20 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811142026.GA26981@x1.redhat.com \
--to=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).