linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/power/64: Use __pa() for physical address computation
@ 2016-08-14  2:07 Rafael J. Wysocki
  2016-08-15  5:10 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-08-14  2:07 UTC (permalink / raw)
  To: Linux PM list, the arch/x86 maintainers; +Cc: Linux Kernel Mailing List

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The value of temp_level4_pgt is the physical address of the
top-level page directory, so use __pa() to compute it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 arch/x86/power/hibernate_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/arch/x86/power/hibernate_64.c
===================================================================
--- linux-pm.orig/arch/x86/power/hibernate_64.c
+++ linux-pm/arch/x86/power/hibernate_64.c
@@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi
 			return result;
 	}
 
-	temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET;
+	temp_level4_pgt = __pa(pgd);
 	return 0;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/power/64: Use __pa() for physical address computation
  2016-08-14  2:07 [PATCH] x86/power/64: Use __pa() for physical address computation Rafael J. Wysocki
@ 2016-08-15  5:10 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2016-08-15  5:10 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux PM list, the arch/x86 maintainers,
	Linux Kernel Mailing List


* Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The value of temp_level4_pgt is the physical address of the
> top-level page directory, so use __pa() to compute it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  arch/x86/power/hibernate_64.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/arch/x86/power/hibernate_64.c
> ===================================================================
> --- linux-pm.orig/arch/x86/power/hibernate_64.c
> +++ linux-pm/arch/x86/power/hibernate_64.c
> @@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi
>  			return result;
>  	}
>  
> -	temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET;
> +	temp_level4_pgt = __pa(pgd);
>  	return 0;
>  }

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-15  5:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-14  2:07 [PATCH] x86/power/64: Use __pa() for physical address computation Rafael J. Wysocki
2016-08-15  5:10 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).