From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Chen, Yu C" <yu.c.chen@intel.com>,
Linux PM List <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <lenb@kernel.org>, Takashi Iwai <tiwai@suse.de>,
Benoit Goby <benoit@android.com>
Subject: Re: [PATCH 0/2][RFC] PM / sleep: Expose DPM watchdog timeout to sysfs
Date: Fri, 19 Aug 2016 00:32:26 +0200 [thread overview]
Message-ID: <20160818223226.GA5055@amd> (raw)
In-Reply-To: <CAJZ5v0joOobOPUT21M=A-=B7FD3D=08VJbt+k+9wXwwT7jiMVw@mail.gmail.com>
Hi!
> >> > > +++ linux/Documentation/kernel-parameters.txt
> >> > > @@ -2749,6 +2749,8 @@ bytes respectively. Such letter suffixes
> >> > > nowatchdog [KNL] Disable both lockup detectors, i.e.
> >> > > soft-lockup and NMI watchdog (hard-lockup).
> >> > >
> >> > > + no_dpm_watchdog [KNL] Disable the device suspend/resume
> >> > watchdog.
> >> > > +
> >> > > nowb [ARM]
> >> > >
> >> > > nox2apic [X86-64,APIC] Do not enable x2APIC mode.
> >> >
> >> > Do we really need the new cmdline option? Can we just tell people to disable
> >> > DPM_WATCHDOG completely?
> >> >
> >> > Is there reason to keep the DPM_WATCHDOG? Did it find some real bugs lately?
> >> >
> >> We can tell users to disable the DPM_WATCHDOG, maybe some android people would like
> >> to use this feature to track/confirm hardware/firmware issues.
> >> I'm ok with only adjusting the timeout from 60 to 120.
> >
> > I believe that's the best solution for now. (Android people often
> > claim commandline is hard for them to use...)
>
> So maybe DPM_WATCHDOG should depend on EXPERT?
I'd say so, yes.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2016-08-19 0:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 12:29 [PATCH 0/2][RFC] PM / sleep: Expose DPM watchdog timeout to sysfs Chen Yu
2016-08-11 12:29 ` [PATCH 1/2][RFC] PM / sleep: Make DPM watchdog depend on PM_SLEEP Chen Yu
2016-08-12 0:40 ` Rafael J. Wysocki
2016-08-11 12:29 ` [PATCH 2/2][RFC] PM / sleep: Expose DPM watchdog timeout to sysfs Chen Yu
2016-08-11 18:54 ` [PATCH 0/2][RFC] " Pavel Machek
2016-08-12 0:39 ` Rafael J. Wysocki
2016-08-12 2:52 ` Chen Yu
2016-08-12 6:33 ` Pavel Machek
2016-08-12 10:49 ` Chen, Yu C
2016-08-12 11:25 ` Rafael J. Wysocki
2016-08-17 3:43 ` Chen Yu
2016-08-18 12:06 ` Pavel Machek
2016-08-18 17:44 ` Chen, Yu C
2016-08-18 18:42 ` Pavel Machek
2016-08-18 22:22 ` Rafael J. Wysocki
2016-08-18 22:32 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818223226.GA5055@amd \
--to=pavel@ucw.cz \
--cc=benoit@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).