linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javi Merino <javi.merino@arm.com>
To: Inhyuk Kang <hugh.kang@lge.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	amit.kachhap@gmail.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Eduardo Valentin <edubezval@gmail.com>,
	Rui Zhang <rui.zhang@intel.com>
Subject: Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
Date: Thu, 8 Sep 2016 09:26:00 +0100	[thread overview]
Message-ID: <20160908082600.GA3112@e104805> (raw)
In-Reply-To: <1473208539-17685-1-git-send-email-hugh.kang@lge.com>

On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.

Yep, my bad.  Thanks for fixing it!

> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>

Acked-by: Javi Merino <javi.merino@arm.com>

> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
>   *	cpufreq frequencies.
>   * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
>   * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
>   * @time_in_idle: previous reading of the absolute time that this cpu was idle
>   * @time_in_idle_timestamp: wall time of the last invocation of
>   *	get_cpu_idle_time_us()
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2016-09-08  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  0:35 [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Inhyuk Kang
2016-09-07  5:04 ` Viresh Kumar
2016-09-08  8:26 ` Javi Merino [this message]
2016-09-19  0:12   ` 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908082600.GA3112@e104805 \
    --to=javi.merino@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=hugh.kang@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).