From: Pavel Machek <pavel@ucw.cz>
To: Anisse Astier <anisse@astier.eu>
Cc: David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-pm@vger.kernel.org, Mathias Krause <minipli@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Laura Abbott <labbott@fedoraproject.org>,
linux-mm@kvack.org, Brad Spengler <spender@grsecurity.net>,
Jianyu Zhan <nasa4836@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yves-Alexis Perez <corsac@debian.org>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Len Brown <len.brown@intel.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
PaX Team <pageexec@freemail.hu>,
Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] PM / Hibernate: allow hibernation with PAGE_POISONING_ZERO
Date: Mon, 12 Sep 2016 19:47:47 +0200 [thread overview]
Message-ID: <20160912174747.GA8285@amd> (raw)
In-Reply-To: <CALUN=qJNX6HqrwXkk--8u0PiOxV-USE4tEouqimXPiRaobtAEw@mail.gmail.com>
Hi!
On Mon 2016-09-12 17:19:54, Anisse Astier wrote:
> Le 12 sept. 2016 13:32, "Pavel Machek" <pavel@ucw.cz> a écrit :
> >
> > On Fri 2016-09-09 10:43:32, Anisse Astier wrote:
> > > PAGE_POISONING_ZERO disables zeroing new pages on alloc, they are
> > > poisoned (zeroed) as they become available.
> > > In the hibernate use case, free pages will appear in the system without
> > > being cleared, left there by the loading kernel.
> > >
> > > This patch will make sure free pages are cleared on resume when
> > > PAGE_POISONING_ZERO is enabled. We free the pages just after resume
> > > because we can't do it later: going through any device resume code might
> > > allocate some memory and invalidate the free pages bitmap.
> > >
> > > Thus we don't need to disable hibernation when PAGE_POISONING_ZERO is
> > > enabled.
> > >
> > > Signed-off-by: Anisse Astier <anisse@astier.eu>
> > > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > > Cc: Laura Abbott <labbott@fedoraproject.org>
> > > Cc: Mel Gorman <mgorman@suse.de>
> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> >
> > Looks reasonable to me.
> >
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> >
> > Actually.... this takes basically zero time come. Do we want to do it
> > unconditionally?
> >
> > (Yes, it is free memory, but for sake of debugging, I guess zeros are
> > preffered to random content that changed during hibernation.)
> >
> > (But that does not change the Ack.)
> >
> > Best regards,
> >
> Pavel
> > --
>
> I have no opposition on doing this unconditionally. I can send a v2 as soon
> as I get closer to a computer.
Actually, I'd keep this one as is, when it works and there are no
problems for a release or so, we can delete the ifdefs.
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-12 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 8:43 [PATCH] PM / Hibernate: allow hibernation with PAGE_POISONING_ZERO Anisse Astier
2016-09-09 18:29 ` Kees Cook
2016-09-12 11:32 ` Pavel Machek
2016-09-12 15:19 ` Anisse Astier
2016-09-12 17:47 ` Pavel Machek [this message]
2016-09-14 1:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912174747.GA8285@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=anisse@astier.eu \
--cc=corsac@debian.org \
--cc=dave.hansen@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@fedoraproject.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minipli@googlemail.com \
--cc=nasa4836@gmail.com \
--cc=pageexec@freemail.hu \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=spender@grsecurity.net \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).