From: Sebastian Reichel <sre@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>
Cc: "Andrew F . Davis" <afd@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Ranostay <matt@ranostay.consulting>
Subject: Re: [PATCH 1/2] power: bq27xxx_battery: add configurable poll_interval by sysfs
Date: Mon, 19 Sep 2016 21:46:03 +0200 [thread overview]
Message-ID: <20160919194602.isutlr2thnyxck6m@earth> (raw)
In-Reply-To: <1474083775-30185-2-git-send-email-matt@ranostay.consulting>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hi,
On Fri, Sep 16, 2016 at 08:42:54PM -0700, Matt Ranostay wrote:
> Allow the poll_interval to be runtime configurable via an sysfs
> entry. This is needed for udev control of the poll interval.
>
> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
> ---
> drivers/power/supply/bq27xxx_battery.c | 48 +++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
New sysfs attributes should be documented in Documentation/ABI.
Also I'm not too keen to add this, as there is already the sysfs
entry for the module parameter. I don't see any reason why udev
should not be able to change that value, so fix udev instead of
duplicating functionality in the kernel.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-19 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 3:42 [PATCH 0/2] power: bq27xxx_battery: add configurable poll_interval Matt Ranostay
2016-09-17 3:42 ` [PATCH 1/2] power: bq27xxx_battery: add configurable poll_interval by sysfs Matt Ranostay
2016-09-19 19:46 ` Sebastian Reichel [this message]
2016-09-20 3:22 ` Matt Ranostay
2016-10-07 18:49 ` Pavel Machek
2016-10-24 3:08 ` Matt Ranostay
2016-10-24 8:23 ` Pavel Machek
2016-10-24 19:51 ` Pavel Machek
2016-10-24 19:55 ` Matt Ranostay
2016-09-17 3:42 ` [PATCH 2/2] power: bq27xxx_battery: allow kernel poll_interval parameter runtime update Matt Ranostay
2016-09-19 19:49 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919194602.isutlr2thnyxck6m@earth \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox