From: Viresh Kumar <viresh.kumar@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: trivial@kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages
Date: Mon, 26 Sep 2016 09:23:25 +0530 [thread overview]
Message-ID: <20160926035325.GE17336@vireshk-i7> (raw)
In-Reply-To: <20160925213543.12267-1-colin.king@canonical.com>
On 25-09-16, 14:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index be42f10..1b9bcd7 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk");
> if (IS_ERR(priv.cpu_clk)) {
> - dev_err(priv.dev, "Unable to get cpuclk");
> + dev_err(priv.dev, "Unable to get cpuclk\n");
> return PTR_ERR(priv.cpu_clk);
> }
>
> @@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
> if (IS_ERR(priv.ddr_clk)) {
> - dev_err(priv.dev, "Unable to get ddrclk");
> + dev_err(priv.dev, "Unable to get ddrclk\n");
> err = PTR_ERR(priv.ddr_clk);
> goto out_cpu;
> }
> @@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.powersave_clk = of_clk_get_by_name(np, "powersave");
> if (IS_ERR(priv.powersave_clk)) {
> - dev_err(priv.dev, "Unable to get powersave");
> + dev_err(priv.dev, "Unable to get powersave\n");
> err = PTR_ERR(priv.powersave_clk);
> goto out_ddr;
> }
> @@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
> if (!err)
> return 0;
>
> - dev_err(priv.dev, "Failed to register cpufreq driver");
> + dev_err(priv.dev, "Failed to register cpufreq driver\n");
>
> clk_disable_unprepare(priv.powersave_clk);
> out_ddr:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2016-09-26 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 21:35 [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Colin King
2016-09-26 3:53 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926035325.GE17336@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox