From: Eduardo Valentin <edubezval@gmail.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Inhyuk Kang <hugh.kang@lge.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: thermal: Fixed governor at each thermal zone
Date: Tue, 27 Sep 2016 06:22:05 -0700 [thread overview]
Message-ID: <20160927132202.GA27366@localhost.localdomain> (raw)
In-Reply-To: <10649ba4-5558-ea3b-a03b-02babd5e63f9@arm.com>
Hello, Lukasz, Inhyuk, Javi,
On Tue, Sep 27, 2016 at 12:52:04PM +0100, Lukasz Luba wrote:
>
> On 27/09/16 02:46, Zhang Rui wrote:
> >On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote:
> >>It is necessary to be added governor at each thermal_zone.
> >>Because some governors should be operated in the during the kernel
> >>booting
> >>in order to avoid heating problem.
> >>
> >>Default governor cannot be covered all thermal zones policy because
> >>some thermal zones want to apply different one.
> >>For example, the power allocator governor operates differently with
> >>step wise governor.
> >>Hence, it is better to parse governor parameter from the device tree.
> >>
> >>Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
> >>
> >The patch looks okay to me.
> >Eduardo, what do you think of this patch?
> Hi Rui,
>
> Beside the fact which Javi pointed out in his email, there is an issue in
> the patch itself.
> The idea behind the patch is good, but the patch should have some
> improvements, i.e:
> - strncpy instead of strcpy,
> - if the governor name is not found in the registered governor's list by
> __find_governor (and then null is set) we should probably switch to default
> governor,
> - add DT documentation,
Also, the idea of the patch is good, almost tempting to do it, but
unfortunately, not acceptable from DT perspective. The patch infringes
two of the DT conceptual and design decision of:
(a) DT should describe hardware, not policy;
(b) DT should describe hardware, not OS specific implementations.
As already pointed by Javi, this patch has already been proposed (more
than one time by different people), but, it still continues to be
unacceptable.
Cheers,
>
> Regards,
> Lukasz
>
next prev parent reply other threads:[~2016-09-27 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 1:18 [PATCH] of: thermal: Fixed governor at each thermal zone Inhyuk Kang
2016-09-27 1:46 ` Zhang Rui
2016-09-27 11:28 ` Javi Merino
2016-09-27 11:52 ` Lukasz Luba
2016-09-27 13:22 ` Eduardo Valentin [this message]
2016-09-28 1:30 ` Zhang Rui
2016-09-28 7:13 ` 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927132202.GA27366@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=hugh.kang@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).