From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
nm@ti.com, sboyd@codeaurora.org,
Viresh Kumar <vireshk@kernel.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
robh@kernel.org, broonie@kernel.org
Subject: Re: [PATCH 3/8] PM / OPP: Manage supply's voltage/current in a separate structure
Date: Thu, 13 Oct 2016 11:12:11 +0530 [thread overview]
Message-ID: <20161013054211.GA2991@vireshk-i7> (raw)
In-Reply-To: <57FEA7F2.3070604@ti.com>
On 12-10-16, 16:15, Dave Gerlach wrote:
> > /**
> >+ * struct dev_pm_opp_supply - Power supply voltage/current values
> >+ * @u_volt: Target voltage in microvolts corresponding to this OPP
> >+ * @u_volt_min: Minimum voltage in microvolts corresponding to thisq OPP
> >+ * @u_volt_max: Maximum voltage in microvolts corresponding to this OPP
> >+ * @u_amp: Maximum current drawn by the device in microamperes
> >+ *
> >+ * This structure stores the voltage/current values for a single power supply.
> >+ */
> >+struct dev_pm_opp_supply {
> >+ unsigned long u_volt;
> >+ unsigned long u_volt_min;
> >+ unsigned long u_volt_max;
> >+ unsigned long u_amp;
> >+};
> >+
> >+/**
>
> This needs to move to include/linux/pm_opp.h, does it not? We need access to
> the actual voltage values from outside of the OPP core if we are going to be
> setting regulators from the platform provided opp_set_rate callback
> described in patch 7.
Yes, will do in V2.
--
viresh
next prev parent reply other threads:[~2016-10-13 5:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 11:56 [PATCH 0/8] PM / OPP: Multiple regulator support Viresh Kumar
2016-10-04 11:56 ` [PATCH 1/8] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
[not found] ` <ea6ba87d6514dcec7bee222b401ab904a78e67e6.1475581665.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-09 1:29 ` Rob Herring
2016-10-04 11:56 ` [PATCH 2/8] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-10-04 11:56 ` [PATCH 3/8] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-10-12 21:15 ` Dave Gerlach
2016-10-13 5:42 ` Viresh Kumar [this message]
2016-10-04 11:56 ` [PATCH 4/8] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
2016-10-04 11:56 ` [PATCH 5/8] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
2016-10-04 11:56 ` [PATCH 6/8] PM / OPP: Separate out _generic_opp_set_rate() Viresh Kumar
2016-10-04 11:56 ` [PATCH 7/8] PM / OPP: Allow platform specific custom opp_set_rate() callbacks Viresh Kumar
2016-10-05 1:29 ` Viresh Kumar
2016-10-11 22:26 ` Rafael J. Wysocki
2016-10-12 2:10 ` [PATCH V2 " Viresh Kumar
2016-10-04 11:56 ` [PATCH 8/8] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-10-10 19:20 ` [PATCH 0/8] PM / OPP: Multiple regulator support Dave Gerlach
2016-10-12 2:11 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013054211.GA2991@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=broonie@kernel.org \
--cc=d-gerlach@ti.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).