From: Sebastian Reichel <sre@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Dennis Gilmore <dennis@ausil.us>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
Date: Wed, 19 Oct 2016 04:56:57 +0200 [thread overview]
Message-ID: <20161019025656.564mntn7mt7ei36m@earth> (raw)
In-Reply-To: <20161019025154.rmw56aoh27wbrene@earth>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Hi,
On Wed, Oct 19, 2016 at 04:51:55AM +0200, Sebastian Reichel wrote:
> > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> > index b1b8658..d35a5fe 100644
> > --- a/drivers/mfd/axp20x-i2c.c
> > +++ b/drivers/mfd/axp20x-i2c.c
> > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> > };
> > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
> >
> > -/*
> > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> > - */
> > static const struct i2c_device_id axp20x_i2c_id[] = {
> > + { "axp152", 0 },
> > + { "axp202", 0 },
> > + { "axp209", 0 },
> > + { "axp221", 0 },
> > { },
> > };
> > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> Thanks, queued.
My mistake. It should obviously go through mfd. So take this instead:
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-10-19 2:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 15:51 [PATCH 0/1] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading Hans de Goede
2016-10-05 15:51 ` [PATCH] " Hans de Goede
2016-10-18 5:25 ` Chen-Yu Tsai
2016-10-18 10:25 ` Hans de Goede
2016-10-24 10:09 ` Lee Jones
2016-10-24 10:17 ` Wolfram Sang
2016-10-24 10:34 ` Lee Jones
2016-10-24 10:47 ` Wolfram Sang
2016-10-26 14:00 ` Lee Jones
2016-10-19 2:51 ` Sebastian Reichel
2016-10-19 2:56 ` Sebastian Reichel [this message]
2016-10-26 14:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019025656.564mntn7mt7ei36m@earth \
--to=sre@kernel.org \
--cc=dennis@ausil.us \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox