* [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520
@ 2016-11-04 18:33 Andrew F. Davis
2016-11-05 17:36 ` Pali Rohár
2016-11-23 23:08 ` Sebastian Reichel
0 siblings, 2 replies; 4+ messages in thread
From: Andrew F. Davis @ 2016-11-04 18:33 UTC (permalink / raw)
To: Pali Rohár, Sebastian Reichel
Cc: linux-pm, linux-kernel, Andrew F . Davis
The BQ27510 and BQ27520 use a slightly different register map than the
BQ27500, add a new type enum and add these gauges to it.
Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
Based-on-patch-by: Kenneth R. Crudup <kenny@panix.com>
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/power/supply/bq27xxx_battery.c | 41 +++++++++++++++++++++++++++++-
drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
include/linux/power/bq27xxx_battery.h | 3 ++-
3 files changed, 44 insertions(+), 4 deletions(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index 3b0dbc6..bccb3f5 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -164,6 +164,25 @@ static u8 bq27xxx_regs[][BQ27XXX_REG_MAX] = {
[BQ27XXX_REG_DCAP] = 0x3c,
[BQ27XXX_REG_AP] = INVALID_REG_ADDR,
},
+ [BQ27510] = {
+ [BQ27XXX_REG_CTRL] = 0x00,
+ [BQ27XXX_REG_TEMP] = 0x06,
+ [BQ27XXX_REG_INT_TEMP] = 0x28,
+ [BQ27XXX_REG_VOLT] = 0x08,
+ [BQ27XXX_REG_AI] = 0x14,
+ [BQ27XXX_REG_FLAGS] = 0x0a,
+ [BQ27XXX_REG_TTE] = 0x16,
+ [BQ27XXX_REG_TTF] = INVALID_REG_ADDR,
+ [BQ27XXX_REG_TTES] = 0x1a,
+ [BQ27XXX_REG_TTECP] = INVALID_REG_ADDR,
+ [BQ27XXX_REG_NAC] = 0x0c,
+ [BQ27XXX_REG_FCC] = 0x12,
+ [BQ27XXX_REG_CYCT] = 0x1e,
+ [BQ27XXX_REG_AE] = INVALID_REG_ADDR,
+ [BQ27XXX_REG_SOC] = 0x20,
+ [BQ27XXX_REG_DCAP] = 0x2e,
+ [BQ27XXX_REG_AP] = INVALID_REG_ADDR,
+ },
[BQ27530] = {
[BQ27XXX_REG_CTRL] = 0x00,
[BQ27XXX_REG_TEMP] = 0x06,
@@ -302,6 +321,24 @@ static enum power_supply_property bq27500_battery_props[] = {
POWER_SUPPLY_PROP_MANUFACTURER,
};
+static enum power_supply_property bq27510_battery_props[] = {
+ POWER_SUPPLY_PROP_STATUS,
+ POWER_SUPPLY_PROP_PRESENT,
+ POWER_SUPPLY_PROP_VOLTAGE_NOW,
+ POWER_SUPPLY_PROP_CURRENT_NOW,
+ POWER_SUPPLY_PROP_CAPACITY,
+ POWER_SUPPLY_PROP_CAPACITY_LEVEL,
+ POWER_SUPPLY_PROP_TEMP,
+ POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW,
+ POWER_SUPPLY_PROP_TECHNOLOGY,
+ POWER_SUPPLY_PROP_CHARGE_FULL,
+ POWER_SUPPLY_PROP_CHARGE_NOW,
+ POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
+ POWER_SUPPLY_PROP_CYCLE_COUNT,
+ POWER_SUPPLY_PROP_HEALTH,
+ POWER_SUPPLY_PROP_MANUFACTURER,
+};
+
static enum power_supply_property bq27530_battery_props[] = {
POWER_SUPPLY_PROP_STATUS,
POWER_SUPPLY_PROP_PRESENT,
@@ -385,6 +422,7 @@ static struct {
BQ27XXX_PROP(BQ27000, bq27000_battery_props),
BQ27XXX_PROP(BQ27010, bq27010_battery_props),
BQ27XXX_PROP(BQ27500, bq27500_battery_props),
+ BQ27XXX_PROP(BQ27510, bq27510_battery_props),
BQ27XXX_PROP(BQ27530, bq27530_battery_props),
BQ27XXX_PROP(BQ27541, bq27541_battery_props),
BQ27XXX_PROP(BQ27545, bq27545_battery_props),
@@ -635,7 +673,8 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di)
*/
static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags)
{
- if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545)
+ if (di->chip == BQ27500 || di->chip == BQ27510 ||
+ di->chip == BQ27541 || di->chip == BQ27545)
return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
if (di->chip == BQ27530 || di->chip == BQ27421)
return flags & BQ27XXX_FLAG_OT;
diff --git a/drivers/power/supply/bq27xxx_battery_i2c.c b/drivers/power/supply/bq27xxx_battery_i2c.c
index 85d4ea2..5c5c3a6 100644
--- a/drivers/power/supply/bq27xxx_battery_i2c.c
+++ b/drivers/power/supply/bq27xxx_battery_i2c.c
@@ -149,8 +149,8 @@ static const struct i2c_device_id bq27xxx_i2c_id_table[] = {
{ "bq27200", BQ27000 },
{ "bq27210", BQ27010 },
{ "bq27500", BQ27500 },
- { "bq27510", BQ27500 },
- { "bq27520", BQ27500 },
+ { "bq27510", BQ27510 },
+ { "bq27520", BQ27510 },
{ "bq27530", BQ27530 },
{ "bq27531", BQ27530 },
{ "bq27541", BQ27541 },
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h
index e30deb0..bed9557 100644
--- a/include/linux/power/bq27xxx_battery.h
+++ b/include/linux/power/bq27xxx_battery.h
@@ -4,7 +4,8 @@
enum bq27xxx_chip {
BQ27000 = 1, /* bq27000, bq27200 */
BQ27010, /* bq27010, bq27210 */
- BQ27500, /* bq27500, bq27510, bq27520 */
+ BQ27500, /* bq27500 */
+ BQ27510, /* bq27510, bq27520 */
BQ27530, /* bq27530, bq27531 */
BQ27541, /* bq27541, bq27542, bq27546, bq27742 */
BQ27545, /* bq27545 */
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520
2016-11-04 18:33 [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520 Andrew F. Davis
@ 2016-11-05 17:36 ` Pali Rohár
2016-11-23 23:08 ` Sebastian Reichel
1 sibling, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2016-11-05 17:36 UTC (permalink / raw)
To: Andrew F. Davis; +Cc: Sebastian Reichel, linux-pm, linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 4907 bytes --]
On Friday 04 November 2016 19:33:13 Andrew F. Davis wrote:
> The BQ27510 and BQ27520 use a slightly different register map than
> the BQ27500, add a new type enum and add these gauges to it.
>
> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for
> additional bq27xxx family devices") Based-on-patch-by: Kenneth R.
> Crudup <kenny@panix.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 41
> +++++++++++++++++++++++++++++-
> drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
> include/linux/power/bq27xxx_battery.h | 3 ++-
> 3 files changed, 44 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c
> b/drivers/power/supply/bq27xxx_battery.c index 3b0dbc6..bccb3f5
> 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -164,6 +164,25 @@ static u8 bq27xxx_regs[][BQ27XXX_REG_MAX] = {
> [BQ27XXX_REG_DCAP] = 0x3c,
> [BQ27XXX_REG_AP] = INVALID_REG_ADDR,
> },
> + [BQ27510] = {
> + [BQ27XXX_REG_CTRL] = 0x00,
> + [BQ27XXX_REG_TEMP] = 0x06,
> + [BQ27XXX_REG_INT_TEMP] = 0x28,
> + [BQ27XXX_REG_VOLT] = 0x08,
> + [BQ27XXX_REG_AI] = 0x14,
> + [BQ27XXX_REG_FLAGS] = 0x0a,
> + [BQ27XXX_REG_TTE] = 0x16,
> + [BQ27XXX_REG_TTF] = INVALID_REG_ADDR,
> + [BQ27XXX_REG_TTES] = 0x1a,
> + [BQ27XXX_REG_TTECP] = INVALID_REG_ADDR,
> + [BQ27XXX_REG_NAC] = 0x0c,
> + [BQ27XXX_REG_FCC] = 0x12,
> + [BQ27XXX_REG_CYCT] = 0x1e,
> + [BQ27XXX_REG_AE] = INVALID_REG_ADDR,
> + [BQ27XXX_REG_SOC] = 0x20,
> + [BQ27XXX_REG_DCAP] = 0x2e,
> + [BQ27XXX_REG_AP] = INVALID_REG_ADDR,
> + },
> [BQ27530] = {
> [BQ27XXX_REG_CTRL] = 0x00,
> [BQ27XXX_REG_TEMP] = 0x06,
> @@ -302,6 +321,24 @@ static enum power_supply_property
> bq27500_battery_props[] = { POWER_SUPPLY_PROP_MANUFACTURER,
> };
>
> +static enum power_supply_property bq27510_battery_props[] = {
> + POWER_SUPPLY_PROP_STATUS,
> + POWER_SUPPLY_PROP_PRESENT,
> + POWER_SUPPLY_PROP_VOLTAGE_NOW,
> + POWER_SUPPLY_PROP_CURRENT_NOW,
> + POWER_SUPPLY_PROP_CAPACITY,
> + POWER_SUPPLY_PROP_CAPACITY_LEVEL,
> + POWER_SUPPLY_PROP_TEMP,
> + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW,
> + POWER_SUPPLY_PROP_TECHNOLOGY,
> + POWER_SUPPLY_PROP_CHARGE_FULL,
> + POWER_SUPPLY_PROP_CHARGE_NOW,
> + POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> + POWER_SUPPLY_PROP_CYCLE_COUNT,
> + POWER_SUPPLY_PROP_HEALTH,
> + POWER_SUPPLY_PROP_MANUFACTURER,
> +};
> +
> static enum power_supply_property bq27530_battery_props[] = {
> POWER_SUPPLY_PROP_STATUS,
> POWER_SUPPLY_PROP_PRESENT,
> @@ -385,6 +422,7 @@ static struct {
> BQ27XXX_PROP(BQ27000, bq27000_battery_props),
> BQ27XXX_PROP(BQ27010, bq27010_battery_props),
> BQ27XXX_PROP(BQ27500, bq27500_battery_props),
> + BQ27XXX_PROP(BQ27510, bq27510_battery_props),
> BQ27XXX_PROP(BQ27530, bq27530_battery_props),
> BQ27XXX_PROP(BQ27541, bq27541_battery_props),
> BQ27XXX_PROP(BQ27545, bq27545_battery_props),
> @@ -635,7 +673,8 @@ static int bq27xxx_battery_read_pwr_avg(struct
> bq27xxx_device_info *di) */
> static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di,
> u16 flags) {
> - if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip ==
> BQ27545) + if (di->chip == BQ27500 || di->chip == BQ27510 ||
> + di->chip == BQ27541 || di->chip == BQ27545)
> return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
> if (di->chip == BQ27530 || di->chip == BQ27421)
> return flags & BQ27XXX_FLAG_OT;
This function should be converted to switch/case blocks... those
if/or/return conditions are now too big.
> diff --git a/drivers/power/supply/bq27xxx_battery_i2c.c
> b/drivers/power/supply/bq27xxx_battery_i2c.c index 85d4ea2..5c5c3a6
> 100644
> --- a/drivers/power/supply/bq27xxx_battery_i2c.c
> +++ b/drivers/power/supply/bq27xxx_battery_i2c.c
> @@ -149,8 +149,8 @@ static const struct i2c_device_id
> bq27xxx_i2c_id_table[] = { { "bq27200", BQ27000 },
> { "bq27210", BQ27010 },
> { "bq27500", BQ27500 },
> - { "bq27510", BQ27500 },
> - { "bq27520", BQ27500 },
> + { "bq27510", BQ27510 },
> + { "bq27520", BQ27510 },
> { "bq27530", BQ27530 },
> { "bq27531", BQ27530 },
> { "bq27541", BQ27541 },
> diff --git a/include/linux/power/bq27xxx_battery.h
> b/include/linux/power/bq27xxx_battery.h index e30deb0..bed9557
> 100644
> --- a/include/linux/power/bq27xxx_battery.h
> +++ b/include/linux/power/bq27xxx_battery.h
> @@ -4,7 +4,8 @@
> enum bq27xxx_chip {
> BQ27000 = 1, /* bq27000, bq27200 */
> BQ27010, /* bq27010, bq27210 */
> - BQ27500, /* bq27500, bq27510, bq27520 */
> + BQ27500, /* bq27500 */
> + BQ27510, /* bq27510, bq27520 */
> BQ27530, /* bq27530, bq27531 */
> BQ27541, /* bq27541, bq27542, bq27546, bq27742 */
> BQ27545, /* bq27545 */
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520
2016-11-04 18:33 [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520 Andrew F. Davis
2016-11-05 17:36 ` Pali Rohár
@ 2016-11-23 23:08 ` Sebastian Reichel
2016-11-28 17:13 ` Andrew F. Davis
1 sibling, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2016-11-23 23:08 UTC (permalink / raw)
To: Andrew F. Davis; +Cc: Pali Rohár, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
Hi,
On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote:
> The BQ27510 and BQ27520 use a slightly different register map than the
> BQ27500, add a new type enum and add these gauges to it.
>
> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
> Based-on-patch-by: Kenneth R. Crudup <kenny@panix.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 41 +++++++++++++++++++++++++++++-
> drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
> include/linux/power/bq27xxx_battery.h | 3 ++-
> 3 files changed, 44 insertions(+), 4 deletions(-)
Queued into for-next. I think pali's hint, that bq27xxx_battery_overtemp()
should be implemented using a switch-case is valid to make the code more
readable. Please provide this change as follow-up patch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520
2016-11-23 23:08 ` Sebastian Reichel
@ 2016-11-28 17:13 ` Andrew F. Davis
0 siblings, 0 replies; 4+ messages in thread
From: Andrew F. Davis @ 2016-11-28 17:13 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Pali Rohár, linux-pm, linux-kernel
On 11/23/2016 05:08 PM, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote:
>> The BQ27510 and BQ27520 use a slightly different register map than the
>> BQ27500, add a new type enum and add these gauges to it.
>>
>> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
>> Based-on-patch-by: Kenneth R. Crudup <kenny@panix.com>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>> drivers/power/supply/bq27xxx_battery.c | 41 +++++++++++++++++++++++++++++-
>> drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
>> include/linux/power/bq27xxx_battery.h | 3 ++-
>> 3 files changed, 44 insertions(+), 4 deletions(-)
>
> Queued into for-next. I think pali's hint, that bq27xxx_battery_overtemp()
> should be implemented using a switch-case is valid to make the code more
> readable. Please provide this change as follow-up patch.
>
I think there may be better ways than even switch-case, perhaps we can
add additional info flags to the part's description tables, then just
branch on that for each accessor type.
Anyway, I'll see what I can to to clean this up when I get some bandwidth.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-28 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04 18:33 [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520 Andrew F. Davis
2016-11-05 17:36 ` Pali Rohár
2016-11-23 23:08 ` Sebastian Reichel
2016-11-28 17:13 ` Andrew F. Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).