From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
nm@ti.com, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org
Subject: Re: [PATCH V3 0/9] PM / OPP: Multiple regulator support
Date: Wed, 9 Nov 2016 17:19:33 -0800 [thread overview]
Message-ID: <20161110011933.GW16026@codeaurora.org> (raw)
In-Reply-To: <20161102045100.GD10786@vireshk-i7>
On 11/02, Viresh Kumar wrote:
> On 26-10-16, 12:02, Viresh Kumar wrote:
> > Hi,
> >
> > Some platforms (like TI) have complex DVFS configuration for CPU
> > devices, where multiple regulators are required to be configured to
> > change DVFS state of the device. This was explained well by Nishanth
> > earlier [1].
> >
> > One of the major complaints around multiple regulators case was that the
> > DT isn't responsible in any way to represent the ordering in which
> > multiple supplies need to be programmed, before or after frequency
> > change. It was considered in this patch and such information is left to
> > the platform specific OPP driver now, which can register its own
> > opp_set_rate() callback with the OPP core and the OPP core will then
> > call it during DVFS.
> >
> > The patches are tested on Exynos5250 (Dual A15). I have hacked around DT
> > and code to pass values for multiple regulators and verified that they
> > are all properly read by the kernel (using debugfs interface).
> >
> > Dave Gerlach has already tested it on the real TI platforms and it works
> > well for him.
> >
> > This is rebased over: linux-next branch in the PM tree.
> >
> > V2->V3:
> > - The last patch is new
> > - Removed a debug leftover pr_info() message
> > - Renamed few names as s/set_rate/set_opp
> > - Removed a TODO comment (as it is done now with this series)
> > - created struct for min_uV and max_uV
> > - kerneldoc comments for structures in pm_opp.h
> > - s/const char */const char * const
> > - use kasprintf()
> > - Some more minor reformatting
> > - More Ack/RBY tags added
>
> @Stephen: Can you please provide further comments or Acks ?
>
Where did we end up on the topic of RCU usage in OPP? I'd rather
we figure that out before investing more time in reviewing code
that we may end up completely rewriting in the future.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-10 1:19 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 6:32 [PATCH V3 0/9] PM / OPP: Multiple regulator support Viresh Kumar
2016-10-26 6:32 ` [PATCH V3 1/9] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
2016-11-09 14:58 ` Mark Brown
2016-11-10 4:04 ` Viresh Kumar
2016-11-10 16:36 ` Mark Brown
2016-11-10 18:09 ` Viresh Kumar
2016-11-10 22:51 ` Stephen Boyd
2016-11-11 3:11 ` Viresh Kumar
2016-11-15 1:59 ` Rob Herring
2016-11-15 2:13 ` Stephen Boyd
2016-11-15 3:31 ` Viresh Kumar
2016-11-15 18:56 ` Stephen Boyd
2016-11-15 22:11 ` Dave Gerlach
2016-11-16 3:18 ` Viresh Kumar
[not found] ` <20161115185645.GA25626-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-16 3:08 ` Viresh Kumar
2016-10-26 6:32 ` [PATCH V3 2/9] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-10-26 6:32 ` [PATCH V3 3/9] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-10-26 6:32 ` [PATCH V3 4/9] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
2016-10-26 6:33 ` [PATCH V3 5/9] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
2016-10-26 6:33 ` [PATCH V3 6/9] PM / OPP: Separate out _generic_opp_set_rate() Viresh Kumar
2016-10-26 6:33 ` [PATCH V3 7/9] PM / OPP: Allow platform specific custom set_opp() callbacks Viresh Kumar
2016-10-26 6:33 ` [PATCH V3 8/9] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-10-26 6:33 ` [PATCH V3 9/9] PM / OPP: Don't assume platform doesn't have regulators Viresh Kumar
2016-11-10 1:17 ` Stephen Boyd
2016-11-10 5:16 ` [PATCH V4 " Viresh Kumar
2016-11-02 4:51 ` [PATCH V3 0/9] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-10 1:19 ` Stephen Boyd [this message]
2016-11-10 4:11 ` Viresh Kumar
2016-11-15 22:10 ` [TEST PATCH] WIP: Test OPP multi regulator support with ti-opp-domain driver Dave Gerlach
2016-11-16 1:38 ` kbuild test robot
2016-11-16 2:01 ` kbuild test robot
2016-11-16 3:27 ` Viresh Kumar
2016-11-18 3:06 ` [PATCH V3 0/9] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-18 10:43 ` Mark Brown
2016-11-22 3:49 ` Viresh Kumar
2016-11-22 18:41 ` Mark Brown
2016-11-23 3:46 ` Viresh Kumar
2016-11-23 12:29 ` Mark Brown
2016-11-24 5:07 ` Viresh Kumar
2016-11-24 10:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110011933.GW16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=d-gerlach@ti.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).