* [patch] PM / Domains: Fix a warning message
@ 2016-11-10 12:52 Dan Carpenter
2016-11-10 16:33 ` Pavel Machek
2016-11-10 19:25 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-11-10 12:52 UTC (permalink / raw)
To: Rafael J. Wysocki, Lina Iyer
Cc: Kevin Hilman, Ulf Hansson, Pavel Machek, Len Brown,
Greg Kroah-Hartman, linux-pm, kernel-janitors
The first argument of WARN() is the condition, followed by the message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 661737c..7b4d41f 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
* powered on/off in that context.
*/
if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
- WARN("Parent %s of subdomain %s must be IRQ safe\n",
+ WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
genpd->name, subdomain->name);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] PM / Domains: Fix a warning message
2016-11-10 12:52 [patch] PM / Domains: Fix a warning message Dan Carpenter
@ 2016-11-10 16:33 ` Pavel Machek
2016-11-10 19:25 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2016-11-10 16:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rafael J. Wysocki, Lina Iyer, Kevin Hilman, Ulf Hansson,
Len Brown, Greg Kroah-Hartman, linux-pm, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Thu 2016-11-10 15:52:15, Dan Carpenter wrote:
> The first argument of WARN() is the condition, followed by the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] PM / Domains: Fix a warning message
2016-11-10 12:52 [patch] PM / Domains: Fix a warning message Dan Carpenter
2016-11-10 16:33 ` Pavel Machek
@ 2016-11-10 19:25 ` Ulf Hansson
2016-11-14 0:40 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2016-11-10 19:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rafael J. Wysocki, Lina Iyer, Kevin Hilman, Pavel Machek,
Len Brown, Greg Kroah-Hartman, linux-pm@vger.kernel.org,
kernel-janitors
On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The first argument of WARN() is the condition, followed by the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 661737c..7b4d41f 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
> * powered on/off in that context.
> */
> if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
> - WARN("Parent %s of subdomain %s must be IRQ safe\n",
> + WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
> genpd->name, subdomain->name);
> return -EINVAL;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] PM / Domains: Fix a warning message
2016-11-10 19:25 ` Ulf Hansson
@ 2016-11-14 0:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-11-14 0:40 UTC (permalink / raw)
To: Ulf Hansson, Dan Carpenter
Cc: Lina Iyer, Kevin Hilman, Pavel Machek, Len Brown,
Greg Kroah-Hartman, linux-pm@vger.kernel.org, kernel-janitors
On Thursday, November 10, 2016 08:25:36 PM Ulf Hansson wrote:
> On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The first argument of WARN() is the condition, followed by the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-14 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 12:52 [patch] PM / Domains: Fix a warning message Dan Carpenter
2016-11-10 16:33 ` Pavel Machek
2016-11-10 19:25 ` Ulf Hansson
2016-11-14 0:40 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).