From: Mark Greer <mgreer@animalcreek.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property
Date: Tue, 15 Nov 2016 10:29:10 -0700 [thread overview]
Message-ID: <20161115172910.GA32729@animalcreek.com> (raw)
In-Reply-To: <20161115033831.7620-1-tony@atomide.com>
On Mon, Nov 14, 2016 at 07:38:31PM -0800, Tony Lindgren wrote:
> There's a typo, it should do pm_runtime_get_sync, not put.
>
> Cc: Mark A. Greer <mgreer@animalcreek.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/power/supply/bq24190_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
>
> dev_dbg(bdi->dev, "prop: %d\n", psp);
>
> - pm_runtime_put_sync(bdi->dev);
> + pm_runtime_get_sync(bdi->dev);
>
> switch (psp) {
> case POWER_SUPPLY_PROP_ONLINE:
> --
> 2.10.2
Oops, sorry about that.
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
next prev parent reply other threads:[~2016-11-15 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 3:38 [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property Tony Lindgren
2016-11-15 17:29 ` Mark Greer [this message]
2016-11-23 22:35 ` Sebastian Reichel
2016-11-25 13:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115172910.GA32729@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).