* [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property
@ 2016-11-15 3:38 Tony Lindgren
2016-11-15 17:29 ` Mark Greer
2016-11-23 22:35 ` Sebastian Reichel
0 siblings, 2 replies; 4+ messages in thread
From: Tony Lindgren @ 2016-11-15 3:38 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Mark A . Greer, linux-pm, linux-omap
There's a typo, it should do pm_runtime_get_sync, not put.
Cc: Mark A. Greer <mgreer@animalcreek.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/power/supply/bq24190_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
dev_dbg(bdi->dev, "prop: %d\n", psp);
- pm_runtime_put_sync(bdi->dev);
+ pm_runtime_get_sync(bdi->dev);
switch (psp) {
case POWER_SUPPLY_PROP_ONLINE:
--
2.10.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property
2016-11-15 3:38 [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property Tony Lindgren
@ 2016-11-15 17:29 ` Mark Greer
2016-11-23 22:35 ` Sebastian Reichel
1 sibling, 0 replies; 4+ messages in thread
From: Mark Greer @ 2016-11-15 17:29 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Sebastian Reichel, linux-pm, linux-omap
On Mon, Nov 14, 2016 at 07:38:31PM -0800, Tony Lindgren wrote:
> There's a typo, it should do pm_runtime_get_sync, not put.
>
> Cc: Mark A. Greer <mgreer@animalcreek.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/power/supply/bq24190_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
>
> dev_dbg(bdi->dev, "prop: %d\n", psp);
>
> - pm_runtime_put_sync(bdi->dev);
> + pm_runtime_get_sync(bdi->dev);
>
> switch (psp) {
> case POWER_SUPPLY_PROP_ONLINE:
> --
> 2.10.2
Oops, sorry about that.
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property
2016-11-15 3:38 [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property Tony Lindgren
2016-11-15 17:29 ` Mark Greer
@ 2016-11-23 22:35 ` Sebastian Reichel
2016-11-25 13:34 ` Tony Lindgren
1 sibling, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2016-11-23 22:35 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Mark A . Greer, linux-pm, linux-omap
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Hi,
On Mon, Nov 14, 2016 at 07:38:31PM -0800, Tony Lindgren wrote:
> There's a typo, it should do pm_runtime_get_sync, not put.
>
> Cc: Mark A. Greer <mgreer@animalcreek.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/power/supply/bq24190_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
>
> dev_dbg(bdi->dev, "prop: %d\n", psp);
>
> - pm_runtime_put_sync(bdi->dev);
> + pm_runtime_get_sync(bdi->dev);
>
> switch (psp) {
> case POWER_SUPPLY_PROP_ONLINE:
Thanks, queued to power-supply's for-next branch. I added
Fixes: d7bf353fd0aa3
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property
2016-11-23 22:35 ` Sebastian Reichel
@ 2016-11-25 13:34 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2016-11-25 13:34 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Mark A . Greer, linux-pm, linux-omap
* Sebastian Reichel <sre@kernel.org> [161123 14:35]:
> Hi,
>
> On Mon, Nov 14, 2016 at 07:38:31PM -0800, Tony Lindgren wrote:
> > There's a typo, it should do pm_runtime_get_sync, not put.
> >
> > Cc: Mark A. Greer <mgreer@animalcreek.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> > drivers/power/supply/bq24190_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> > --- a/drivers/power/supply/bq24190_charger.c
> > +++ b/drivers/power/supply/bq24190_charger.c
> > @@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
> >
> > dev_dbg(bdi->dev, "prop: %d\n", psp);
> >
> > - pm_runtime_put_sync(bdi->dev);
> > + pm_runtime_get_sync(bdi->dev);
> >
> > switch (psp) {
> > case POWER_SUPPLY_PROP_ONLINE:
>
> Thanks, queued to power-supply's for-next branch. I added
>
> Fixes: d7bf353fd0aa3
Thanks!
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-25 13:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 3:38 [PATCH] bq24190_charger: Fix PM runtime use for bq24190_battery_set_property Tony Lindgren
2016-11-15 17:29 ` Mark Greer
2016-11-23 22:35 ` Sebastian Reichel
2016-11-25 13:34 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).