From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stratos Karafotis <stratosk@semaphore.gr>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cpufreq: conservative: Fix comment explaining frequency updates
Date: Thu, 17 Nov 2016 09:10:59 +0530 [thread overview]
Message-ID: <20161117034059.GB4894@vireshk-i7> (raw)
In-Reply-To: <4986155b-de07-1a4c-186c-71d90b12e75c@semaphore.gr>
On 16-11-16, 21:27, Stratos Karafotis wrote:
> The original comment about the frequency increase to maximum is wrong.
>
> Both increase and decrease happen at steps.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> -> v2
> Remove a trailing space
>
> drivers/cpufreq/cpufreq_conservative.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> index a48b724..7522ec6 100644
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -55,8 +55,8 @@ static inline unsigned int get_freq_step(struct cs_dbs_tuners *cs_tuners,
> * sampling_down_factor, we check, if current idle time is more than 80%
> * (default), then we try to decrease frequency
> *
> - * Any frequency increase takes it to the maximum frequency. Frequency reduction
> - * happens at minimum steps of 5% (default) of maximum frequency
> + * Frequency updates happen at minimum steps of 5% (default) of maximum
> + * frequency
> */
> static unsigned int cs_dbs_update(struct cpufreq_policy *policy)
> {
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-11-17 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 19:27 [PATCH v2] cpufreq: conservative: Fix comment explaining frequency updates Stratos Karafotis
2016-11-17 3:40 ` Viresh Kumar [this message]
2016-11-24 1:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117034059.GB4894@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stratosk@semaphore.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).