From: Viresh Kumar <viresh.kumar@linaro.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: rjw@rjwysocki.net, morten.rasmussen@arm.com, Juri.Lelli@arm.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP
Date: Thu, 17 Nov 2016 12:19:54 +0530 [thread overview]
Message-ID: <20161117064954.GD4894@vireshk-i7> (raw)
In-Reply-To: <1479250783-74336-2-git-send-email-srinivas.pandruvada@linux.intel.com>
Hi Srinivas,
I don't think other platforms need it for now and so it is fine to
add these to the driver itself.
On 15-11-16, 14:59, Srinivas Pandruvada wrote:
> +static ssize_t show_energy_performance_available_preferences(
Maybe a personal preference, but I would have broken the line after
ssize_t instead of where you have done it.
> + struct cpufreq_policy *policy, char *buf)
> +{
> +static struct freq_attr *hwp_cpufreq_attrs[] = {
> + &energy_performance_preference,
> + &energy_performance_available_preferences,
> + NULL,
> +};
What about adding these to intel_pstate_attr_group instead ?
--
viresh
next prev parent reply other threads:[~2016-11-17 6:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 22:59 [RFC][PATCH] cpufreq: Support of Energy Performance preference Srinivas Pandruvada
2016-11-15 22:59 ` [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP Srinivas Pandruvada
2016-11-17 6:49 ` Viresh Kumar [this message]
2016-11-17 19:31 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117064954.GD4894@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).