From: Juri Lelli <Juri.Lelli@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Robin Randhawa <robin.randhawa@arm.com>,
Steve Muckle <smuckle.linux@gmail.com>,
tkjos@google.com, Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH] cpufreq: schedutil: add up/down frequency transition rate limits
Date: Mon, 21 Nov 2016 12:14:32 +0000 [thread overview]
Message-ID: <20161121121432.GK24383@e106622-lin> (raw)
In-Reply-To: <20161121101946.GI3102@twins.programming.kicks-ass.net>
On 21/11/16 11:19, Peter Zijlstra wrote:
> On Mon, Nov 21, 2016 at 03:38:05PM +0530, Viresh Kumar wrote:
> > On 17-11-16, 10:48, Viresh Kumar wrote:
[...]
> >
> > (Background story for others from my discussion with Rafael on IRC: Rafael
> > proposed that instead of this patch we can add down_rate_limit_delta_us (>0 =)
> > which can be added to rate_limit_us (rate limit while increasing freq) to find
> > the rate limit to be used in the downward direction. And I raised the point
> > that it looks much neater to have separate up and down rate_limit_us. I also
> > said that people may have a valid case where they want to keep down_rate_limit
> > lower than up_rate_limit and Rafael wasn't fully sure of any such cases).
> >
>
> Urgh...
>
>
> So no tunables and rate limits here at all please.
>
> During LPC we discussed the rampup and decay issues and decided that we
> should very much first address them by playing with the PELT stuff.
> Morton was going to play with capping the decay on the util signal. This
> should greatly improve the ramp-up scenario and cure some other wobbles.
>
> The decay can be set by changing the over-all pelt decay, if so desired.
>
Do you mean we might want to change the decay (make it different from
ramp-up) once for all, or maybe we make it tunable so that we can
address different power/perf requirements?
> Also, there was the idea of; once the above ideas have all been
> explored; tying the freq ram rate to the power curve.
>
Yep. That's an interesting one to look at, but it might require some
time.
> So NAK on everything tunable here.
next prev parent reply other threads:[~2016-11-21 12:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 5:18 [PATCH] cpufreq: schedutil: add up/down frequency transition rate limits Viresh Kumar
2016-11-21 10:08 ` Viresh Kumar
2016-11-21 10:19 ` Peter Zijlstra
2016-11-21 10:48 ` Viresh Kumar
2016-11-21 11:12 ` Peter Zijlstra
2016-11-21 11:30 ` Viresh Kumar
2016-11-21 11:48 ` Peter Zijlstra
2016-11-21 12:14 ` Juri Lelli [this message]
2016-11-21 12:26 ` Peter Zijlstra
2016-11-21 13:53 ` Juri Lelli
2016-11-21 14:17 ` Peter Zijlstra
2016-11-21 14:37 ` Juri Lelli
2016-11-21 14:43 ` Peter Zijlstra
2016-11-21 14:59 ` Juri Lelli
2016-11-22 9:27 ` Vincent Guittot
2016-11-22 11:03 ` Patrick Bellasi
2016-11-21 14:59 ` Patrick Bellasi
2016-11-21 15:26 ` Peter Zijlstra
2016-11-21 15:34 ` Peter Zijlstra
2016-11-21 16:24 ` Patrick Bellasi
2016-11-21 16:46 ` Peter Zijlstra
2016-11-21 20:53 ` Rafael J. Wysocki
2016-12-29 3:24 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121121432.GK24383@e106622-lin \
--to=juri.lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robin.randhawa@arm.com \
--cc=smuckle.linux@gmail.com \
--cc=tkjos@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox