From: Brian Norris <briannorris@chromium.org>
To: Caesar Wang <caesar.upstream@gmail.com>
Cc: Caesar Wang <wxt@rock-chips.com>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Barber <smbarber@chromium.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages
Date: Mon, 21 Nov 2016 18:15:07 -0800 [thread overview]
Message-ID: <20161122021506.GA103691@google.com> (raw)
In-Reply-To: <378ade3d-a980-58e4-5253-c16702c74bf3@gmail.com>
On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote:
> CHECK: Alignment should match open parenthesis
> #428: FILE: drivers/thermal/rockchip_thermal.c:428:
> + pr_err("%s: invalid temperature, temp=%d error=%d\n",
> + __func__, temp, error);
>
> CHECK: Alignment should match open parenthesis
> #480: FILE: drivers/thermal/rockchip_thermal.c:480:
> + pr_err("%s: invalid conversion table, mode=%d\n",
> + __func__, table->mode);
What patch are you checking? I ran mine through checkpatch, and there
are no problems. Did you perhaps mangle the tabs into spaces when you
saved the patch?
> I'm ready to resend all rockchip thermal patches. (contain them)
I see no reason to resend so far; the only criticism was on the 1st
patch (a non-critical patch to the core thermal code; the others are
relatively independent, as long as you don't care that I'm adding
another error return without fixing up the broken
CONFIG_THERMAL_EMULATION support).
Brian
next prev parent reply other threads:[~2016-11-22 2:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 23:52 [PATCH 1/3] thermal: handle get_temp() errors properly Brian Norris
2016-11-18 23:52 ` [PATCH 2/3] thermal: rockchip: improve conversion error messages Brian Norris
2016-11-19 3:31 ` Caesar Wang
2016-11-19 3:35 ` Caesar Wang
2016-11-22 1:51 ` Caesar Wang
2016-11-22 2:15 ` Brian Norris [this message]
2016-11-22 2:33 ` Caesar Wang
2016-11-22 3:43 ` Brian Norris
2016-11-22 7:57 ` Zhang Rui
2016-11-22 12:44 ` Caesar Wang
[not found] ` <1479513177-81504-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-11-18 23:52 ` [PATCH 3/3] thermal: rockchip: don't pass table structs by value Brian Norris
2016-11-19 4:03 ` Caesar Wang
2016-11-19 3:21 ` [PATCH 1/3] thermal: handle get_temp() errors properly Caesar Wang
2016-11-19 3:41 ` Eduardo Valentin
2016-11-19 5:30 ` Brian Norris
2016-11-22 7:52 ` Zhang Rui
2016-11-22 11:00 ` Eduardo Valentin
[not found] ` <20161122110045.GB2018-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-22 22:27 ` Brian Norris
2017-09-08 18:15 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122021506.GA103691@google.com \
--to=briannorris@chromium.org \
--cc=caesar.upstream@gmail.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).